Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposals with same names but different origins can be ignored #797

Open
mrennie opened this issue Jun 29, 2016 · 0 comments
Open

Proposals with same names but different origins can be ignored #797

mrennie opened this issue Jun 29, 2016 · 0 comments

Comments

@mrennie
Copy link
Contributor

mrennie commented Jun 29, 2016

If you have two plugins that return a similarly named proposal, the one that was inferred or loaded first (from a definition file) is the only one that is returned, see line 795 onward in tern.js:

for (var prop in srv.cx.props) gather(prop, srv.cx.props[prop][0], 0);

That loop should walk all of the entries in srv.cx.props[prop] and gather them all if they come from different origins (and we are asking for origin information).

See Eclipse Orion bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=496955 for a concrete example. I'll open a pull request for how we fixed the problem in Orion.

mrennie pushed a commit to mrennie/tern that referenced this issue Jun 29, 2016
…#797

Check all properties, not just the first, and check origins before
leaving out same-named properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant