From ad8776d94b154778f4ae36240a917efe0a8a30cc Mon Sep 17 00:00:00 2001 From: "Philippe M. Chiasson" Date: Thu, 23 Sep 2021 22:05:14 -0400 Subject: [PATCH 1/2] Add missing netblock (143.55.64.0/20) to GitHub webhook IP ranges Fixes #224 --- variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/variables.tf b/variables.tf index 80d0760f..5078ac1b 100644 --- a/variables.tf +++ b/variables.tf @@ -153,7 +153,7 @@ variable "allow_github_webhooks" { variable "github_webhooks_cidr_blocks" { description = "List of CIDR blocks used by GitHub webhooks" # This is hardcoded to avoid dependency on github provider. Source: https://api.github.com/meta type = list(string) - default = ["140.82.112.0/20", "185.199.108.0/22", "192.30.252.0/22"] + default = ["140.82.112.0/20", "185.199.108.0/22", "192.30.252.0/22", "143.55.64.0/20"] } variable "whitelist_unauthenticated_cidr_blocks" { From 26a34b14810d43e684061e89de05e8e94c62950f Mon Sep 17 00:00:00 2001 From: Anton Babenko Date: Fri, 24 Sep 2021 10:13:17 +0200 Subject: [PATCH 2/2] docs: Fixed docs --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index cd1af0c0..9a9b8e1c 100644 --- a/README.md +++ b/README.md @@ -331,7 +331,7 @@ allow_github_webhooks = true | [external\_task\_definition\_updates](#input\_external\_task\_definition\_updates) | Enable to allow the task definition to be updated outside of this Terraform module. This should be enabled when using a deployment tool such as ecs-deploy which updates the task definition and will then keep the ECS service using the latest version of the task definition. | `bool` | `false` | no | | [extra\_container\_definitions](#input\_extra\_container\_definitions) | A list of valid container definitions provided as a single valid JSON document. These will be provided as supplimentary to the main Atlantis container definition | `list(any)` | `[]` | no | | [firelens\_configuration](#input\_firelens\_configuration) | The FireLens configuration for the container. This is used to specify and configure a log router for container logs. For more details, see https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_FirelensConfiguration.html | 
object({
    type    = string
    options = map(string)
  })
| `null` | no | -| [github\_webhooks\_cidr\_blocks](#input\_github\_webhooks\_cidr\_blocks) | List of CIDR blocks used by GitHub webhooks | `list(string)` | 
[
  "140.82.112.0/20",
  "185.199.108.0/22",
  "192.30.252.0/22"
]
| no | +| [github\_webhooks\_cidr\_blocks](#input\_github\_webhooks\_cidr\_blocks) | List of CIDR blocks used by GitHub webhooks | `list(string)` | 
[
  "140.82.112.0/20",
  "185.199.108.0/22",
  "192.30.252.0/22",
  "143.55.64.0/20"
]
| no | | [internal](#input\_internal) | Whether the load balancer is internal or external | `bool` | `false` | no | | [mount\_points](#input\_mount\_points) | Container mount points. This is a list of maps, where each map should contain a `containerPath` and `sourceVolume`. The `readOnly` key is optional. | `list(any)` | `[]` | no | | [name](#input\_name) | Name to use on all resources created (VPC, ALB, etc) | `string` | `"atlantis"` | no |