Skip to content

feat: Add support for additional CloudFront metrics #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 12, 2021
Merged

feat: Add support for additional CloudFront metrics #54

merged 4 commits into from
Oct 12, 2021

Conversation

@cageyv
Copy link
Contributor

@cageyv cageyv commented Oct 12, 2021

Description

The resource to get additional CloudFront metrics

@cageyv cageyv marked this pull request as ready for review October 12, 2021 09:25
@cageyv
Copy link
Contributor Author

cageyv commented Oct 12, 2021

LGTM and ready to use

antonbabenko
antonbabenko requested changes Oct 12, 2021
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Could you also update the example to show this feature in action?

@antonbabenko antonbabenko changed the title Feat: add aws_cloudfront_monitoring_subscription feat: Add CloudFront real-time log configuration Oct 12, 2021
@cageyv
Copy link
Contributor Author

cageyv commented Oct 12, 2021

Done
And this is not real-time log configuration (this is a mistake in terraform-aws-provider documentation)
This resource simple enable additional metrics for CloudFront

https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/viewing-cloudfront-metrics.html
https://docs.aws.amazon.com/cloudfront/latest/APIReference/API_CreateMonitoringSubscription.html

@antonbabenko antonbabenko changed the title feat: Add CloudFront real-time log configuration feat: Add support for additional CloudFront metrics Oct 12, 2021
@antonbabenko antonbabenko merged commit eac2977 into terraform-aws-modules:master Oct 12, 2021
@antonbabenko
Copy link
Member

antonbabenko commented Oct 12, 2021

Thanks for the explanation and for this feature.

v2.8.0 has been just released.

@cageyv cageyv deleted the feat/monitoring_subscription branch October 12, 2021 19:27
@github-actions
Copy link

github-actions bot commented Oct 28, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@antonbabenko antonbabenko antonbabenko requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cageyv @antonbabenko