From 4c6925f8e42ed4eb97f001bac1845dc884ad8b01 Mon Sep 17 00:00:00 2001 From: "Edgar R. Sandi" Date: Fri, 18 Nov 2022 21:19:52 -0300 Subject: [PATCH 1/3] add firehose args Signed-off-by: Edgar R. Sandi --- main.tf | 3 +++ variables.tf | 18 ++++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/main.tf b/main.tf index 9b4ed72..ae17a9a 100644 --- a/main.tf +++ b/main.tf @@ -10,6 +10,9 @@ resource "aws_sns_topic" "this" { application_success_feedback_role_arn = var.application_success_feedback_role_arn application_success_feedback_sample_rate = var.application_success_feedback_sample_rate application_failure_feedback_role_arn = var.application_failure_feedback_role_arn + firehose_success_feedback_role_arn = var.firehose_success_feedback_role_arn + firehose_success_feedback_sample_rate = var.firehose_success_feedback_sample_rate + firehose_failure_feedback_role_arn = var.firehose_failure_feedback_role_arn http_success_feedback_role_arn = var.http_success_feedback_role_arn http_success_feedback_sample_rate = var.http_success_feedback_sample_rate http_failure_feedback_role_arn = var.http_failure_feedback_role_arn diff --git a/variables.tf b/variables.tf index 87c684c..0c6120b 100644 --- a/variables.tf +++ b/variables.tf @@ -52,6 +52,24 @@ variable "application_failure_feedback_role_arn" { default = null } +variable "firehose_success_feedback_role_arn" { + description = "The IAM role permitted to receive success feedback for this topic" + type = string + default = null +} + +variable "firehose_success_feedback_sample_rate" { + description = "Percentage of success to sample" + type = string + default = null +} + +variable "firehose_failure_feedback_role_arn" { + description = "IAM role for failure feedback" + type = string + default = null +} + variable "http_success_feedback_role_arn" { description = "The IAM role permitted to receive success feedback for this topic" type = string From 0ad70c342cfe050be6ac7cba291ba7f5af46af01 Mon Sep 17 00:00:00 2001 From: "Edgar R. Sandi" Date: Fri, 18 Nov 2022 21:20:41 -0300 Subject: [PATCH 2/3] chore(doc): update README.md --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 2edb279..0f5c153 100644 --- a/README.md +++ b/README.md @@ -53,6 +53,9 @@ No modules. | [delivery\_policy](#input\_delivery\_policy) | The SNS delivery policy | `string` | `null` | no | | [display\_name](#input\_display\_name) | The display name for the SNS topic | `string` | `null` | no | | [fifo\_topic](#input\_fifo\_topic) | Boolean indicating whether or not to create a FIFO (first-in-first-out) topic | `bool` | `false` | no | +| [firehose\_failure\_feedback\_role\_arn](#input\_firehose\_failure\_feedback\_role\_arn) | IAM role for failure feedback | `string` | `null` | no | +| [firehose\_success\_feedback\_role\_arn](#input\_firehose\_success\_feedback\_role\_arn) | The IAM role permitted to receive success feedback for this topic | `string` | `null` | no | +| [firehose\_success\_feedback\_sample\_rate](#input\_firehose\_success\_feedback\_sample\_rate) | Percentage of success to sample | `string` | `null` | no | | [http\_failure\_feedback\_role\_arn](#input\_http\_failure\_feedback\_role\_arn) | IAM role for failure feedback | `string` | `null` | no | | [http\_success\_feedback\_role\_arn](#input\_http\_success\_feedback\_role\_arn) | The IAM role permitted to receive success feedback for this topic | `string` | `null` | no | | [http\_success\_feedback\_sample\_rate](#input\_http\_success\_feedback\_sample\_rate) | Percentage of success to sample | `string` | `null` | no | From b15eb4c5faf6dc89e73f4ecb79e3686ea51769fd Mon Sep 17 00:00:00 2001 From: Bryant Biggs Date: Sun, 4 Dec 2022 09:59:04 -0500 Subject: [PATCH 3/3] Apply suggestions from code review --- README.md | 2 +- variables.tf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0f5c153..d216e3d 100644 --- a/README.md +++ b/README.md @@ -55,7 +55,7 @@ No modules. | [fifo\_topic](#input\_fifo\_topic) | Boolean indicating whether or not to create a FIFO (first-in-first-out) topic | `bool` | `false` | no | | [firehose\_failure\_feedback\_role\_arn](#input\_firehose\_failure\_feedback\_role\_arn) | IAM role for failure feedback | `string` | `null` | no | | [firehose\_success\_feedback\_role\_arn](#input\_firehose\_success\_feedback\_role\_arn) | The IAM role permitted to receive success feedback for this topic | `string` | `null` | no | -| [firehose\_success\_feedback\_sample\_rate](#input\_firehose\_success\_feedback\_sample\_rate) | Percentage of success to sample | `string` | `null` | no | +| [firehose\_success\_feedback\_sample\_rate](#input\_firehose\_success\_feedback\_sample\_rate) | Percentage of success to sample | `number` | `null` | no | | [http\_failure\_feedback\_role\_arn](#input\_http\_failure\_feedback\_role\_arn) | IAM role for failure feedback | `string` | `null` | no | | [http\_success\_feedback\_role\_arn](#input\_http\_success\_feedback\_role\_arn) | The IAM role permitted to receive success feedback for this topic | `string` | `null` | no | | [http\_success\_feedback\_sample\_rate](#input\_http\_success\_feedback\_sample\_rate) | Percentage of success to sample | `string` | `null` | no | diff --git a/variables.tf b/variables.tf index 0c6120b..b3885a2 100644 --- a/variables.tf +++ b/variables.tf @@ -60,7 +60,7 @@ variable "firehose_success_feedback_role_arn" { variable "firehose_success_feedback_sample_rate" { description = "Percentage of success to sample" - type = string + type = number default = null }