From f2d882e4618f042c735289a52d5ae869813b735f Mon Sep 17 00:00:00 2001 From: Zaar Hai Date: Mon, 14 Nov 2022 17:08:17 +1100 Subject: [PATCH 1/2] ID can't have spaces --- modules/gh-oidc/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/gh-oidc/README.md b/modules/gh-oidc/README.md index 39f363ea..0114f893 100644 --- a/modules/gh-oidc/README.md +++ b/modules/gh-oidc/README.md @@ -57,7 +57,7 @@ jobs: with: workload_identity_provider: ${{ secrets.PROVIDER_NAME }} # this is the output provider_name from the TF module service_account: ${{ secrets.SA_EMAIL }} # this is a SA email configured using the TF module with access to YOUR-GCS-BUCKET - - id: 'list buckets contents' + - id: 'list-buckets-contents' run: |- curl https://storage.googleapis.com/storage/v1/b/YOUR-GCS-BUCKET/o \ --header "Authorization: Bearer ${{ steps.auth.outputs.access_token }}" From 672df1ff460dfc31f5b57885b869ac58778690f5 Mon Sep 17 00:00:00 2001 From: Zaar Hai Date: Mon, 14 Nov 2022 17:08:39 +1100 Subject: [PATCH 2/2] Script-friendly curl --- modules/gh-oidc/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/gh-oidc/README.md b/modules/gh-oidc/README.md index 0114f893..cf73b709 100644 --- a/modules/gh-oidc/README.md +++ b/modules/gh-oidc/README.md @@ -59,7 +59,7 @@ jobs: service_account: ${{ secrets.SA_EMAIL }} # this is a SA email configured using the TF module with access to YOUR-GCS-BUCKET - id: 'list-buckets-contents' run: |- - curl https://storage.googleapis.com/storage/v1/b/YOUR-GCS-BUCKET/o \ + curl -sSf https://storage.googleapis.com/storage/v1/b/YOUR-GCS-BUCKET/o \ --header "Authorization: Bearer ${{ steps.auth.outputs.access_token }}" ```