Skip to content

fix!: Change export service account permission for external backups - roles/storage.objectAdmin #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix!: Change export service account permission for external backups - roles/storage.objectAdmin #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27f56b4
fix(external-backup): after some changes in GCP export methods, new p…
DeLoWaN Oct 15, 2024
43b48e6
chore(external-backup): missing documentation
DeLoWaN Oct 15, 2024
413653a
Merge branch 'master' into objectCreator-to-objectAdmin
imrannayer Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/upgrading_to_sql_db_23.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Upgrading to SQL DB 23.0

The 23.0 release of SQL DB is a backward incompatible release.

# Cloud SQL Service Account role update

Changed `storage.objectCreator` role to `storage.objectAdmin` for Cloud SQL Service Account on the bucket used for exporting the database, due to GCP internal changes in the export process.
2 changes: 1 addition & 1 deletion modules/backup/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ resource "google_storage_bucket_iam_member" "sql_instance_account" {
count = var.enable_export_backup ? 1 : 0
bucket = split("/", var.export_uri)[2] #Get the name of the bucket out of the URI
member = "serviceAccount:${data.google_sql_database_instance.backup_instance.service_account_email_address}"
role = "roles/storage.objectCreator"
role = "roles/storage.objectAdmin"
}

# We want to get notified if there hasn't been at least one successful backup in a day
Expand Down