feat: DA for elastic search #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ocofaigh merged 39 commits into main from da-for-elasticsearch

Mar 28, 2024

Member

Aayush-Abhyarthi commented Feb 12, 2024

Description

(https://github.ibm.com/GoldenEye/issues/issues/7148)

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.


          DA for elastic search

9c20fdd

Aayush-Abhyarthi changed the title ~~DA for elastic search~~ feat: DA for elastic search

Aayush-Abhyarthi and others added 2 commits

February 12, 2024 13:58


          Merge branch 'main' into da-for-elasticsearch


          fix: error

674d90d

Member Author

Aayush-Abhyarthi commented Feb 12, 2024

/run pipeline


          add diagram

dd28f89

Member Author

Aayush-Abhyarthi commented Feb 12, 2024

/run pipeline

maheshwarishikha reviewed

View reviewed changes

solutions/fscloud/README.md Outdated Show resolved Hide resolved

maheshwarishikha reviewed

View reviewed changes

solutions/fscloud/version.tf Outdated Show resolved Hide resolved

maheshwarishikha reviewed

View reviewed changes

tests/pr_test.go Outdated Show resolved Hide resolved

maheshwarishikha reviewed

View reviewed changes

tests/pr_test.go Outdated Show resolved Hide resolved

maheshwarishikha reviewed

View reviewed changes

solutions/fscloud/README.md Outdated Show resolved Hide resolved

maheshwarishikha reviewed

View reviewed changes

solutions/fscloud/main.tf Show resolved Hide resolved


          resolve comments

494c66c

Member Author

Aayush-Abhyarthi commented Feb 16, 2024

/run pipeline


          resolve comments

3c788a7

Member Author

Aayush-Abhyarthi commented Feb 16, 2024

/run pipeline

Aayush-Abhyarthi and others added 3 commits

February 19, 2024 15:39


          Merge branch 'main' into da-for-elasticsearch

136cb40


          update diagram

531c846


          update diagram

66d1fc5

Member Author

Aayush-Abhyarthi commented Feb 19, 2024

/run pipeline


          Merge branch 'main' into da-for-elasticsearch

1e196b6

Aayush-Abhyarthi requested review from daniel-butler-irl and shemau as code owners

February 21, 2024 19:51


          add onboarding files

1869b20

maheshwarishikha reviewed

View reviewed changes

.catalog-onboard-pipeline.yaml Outdated Show resolved Hide resolved

maheshwarishikha reviewed

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

maheshwarishikha reviewed

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

maheshwarishikha reviewed

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

maheshwarishikha reviewed

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved


          update readme

06693d8

Member Author

Aayush-Abhyarthi commented Mar 26, 2024

/run pipeline

Aayush-Abhyarthi requested a review from ocofaigh

March 26, 2024 11:53

ocofaigh requested changes

View reviewed changes

Contributor

ocofaigh left a comment

see comments

.catalog-onboard-pipeline.yaml Outdated Show resolved Hide resolved

solutions/secure/version.tf Outdated Show resolved Hide resolved

solutions/secure/variables.tf Outdated Show resolved Hide resolved

solutions/secure/main.tf Show resolved Hide resolved

solutions/secure/README.md Outdated Show resolved Hide resolved

ibm_catalog.json Outdated Show resolved Hide resolved

solutions/secure/main.tf Outdated Show resolved Hide resolved

tests/pr_test.go Outdated Show resolved Hide resolved

tests/pr_test.go Show resolved Hide resolved


          resolve comments

31212c3

Member Author

Aayush-Abhyarthi commented Mar 27, 2024

/run pipeline


          resolve error

6f6d295

Member Author

Aayush-Abhyarthi commented Mar 27, 2024

/run pipeline

ocofaigh requested changes

View reviewed changes

Contributor

ocofaigh left a comment

Left some comments

ibm_catalog.json Outdated Show resolved Hide resolved

solutions/secure/catalogValidationValues.json.template Outdated Show resolved Hide resolved

solutions/secure/version.tf Outdated Show resolved Hide resolved

tests/pr_test.go Show resolved Hide resolved

tests/pr_test.go Outdated Show resolved Hide resolved

tests/pr_test.go Outdated Show resolved Hide resolved

tests/pr_test.go Outdated Show resolved Hide resolved

Contributor

ocofaigh commented Mar 27, 2024

PS: You need to now skip the upgrade test since the DA code isnt in main branch yet, so upgrade test can't run

Aayush-Abhyarthi added 2 commits

March 27, 2024 11:16


          resolve comments

71d0194


          SKIP UPGRADE TEST

594a92c

Member Author

Aayush-Abhyarthi commented Mar 27, 2024

/run pipeline


          SKIP UPGRADE TEST

b2599f8

Member Author

Aayush-Abhyarthi commented Mar 27, 2024

/run pipeline


          SKIP UPGRADE TEST

319acea

Member Author

Aayush-Abhyarthi commented Mar 27, 2024

/run pipeline


          SKIP UPGRADE TEST

27b4168

Member Author

Aayush-Abhyarthi commented Mar 27, 2024

/run pipeline

Aayush-Abhyarthi requested a review from ocofaigh

March 27, 2024 13:31

maheshwarishikha added 3 commits

March 27, 2024 20:10


          Update ibm_catalog.json

2e7114d


          Update version.tf


          Update README.md

5bdf8b5

Member

maheshwarishikha commented Mar 27, 2024

/run pipeline

ocofaigh approved these changes

View reviewed changes

ocofaigh dismissed SirSpidey’s stale review

March 28, 2024 09:13

changes made - a full doc review will come before GA too

ocofaigh merged commit 59a9e73 into main

ocofaigh deleted the da-for-elasticsearch branch

March 28, 2024 09:14

Contributor

terraform-ibm-modules-ops commented Mar 28, 2024

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

GitHub release
v1.9.0

Your semantic-release bot 📦🚀

terraform-ibm-modules-ops added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

maheshwarishikha maheshwarishikha left review comments

ocofaigh ocofaigh approved these changes

daniel-butler-irl Awaiting requested review from daniel-butler-irl daniel-butler-irl is a code owner

shemau Awaiting requested review from shemau shemau is a code owner

+1 more reviewer

SirSpidey SirSpidey left review comments

Labels