From c9ce6399312ed15c0048e8a8b887fd83e216f429 Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Tue, 29 Aug 2023 17:43:14 +0530 Subject: [PATCH 1/3] feat: add description value in ibm_iam_authorization_policy block --- main.tf | 1 + module-metadata.json | 14 ++++++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/main.tf b/main.tf index 961d75be..c358e01e 100644 --- a/main.tf +++ b/main.tf @@ -36,6 +36,7 @@ resource "ibm_iam_authorization_policy" "kms_policy" { target_service_name = local.kms_service target_resource_instance_id = var.existing_kms_instance_guid roles = ["Reader"] + description = "Allow all ICD Postgres instances in the resource group ${var.resource_group_id} to read from the ${local.kms_service} instance GUID ${var.existing_kms_instance_guid}" } # workaround for https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4478 diff --git a/module-metadata.json b/module-metadata.json index b89cabb1..34fd7dd0 100644 --- a/module-metadata.json +++ b/module-metadata.json @@ -272,6 +272,7 @@ "required": true, "source": [ "ibm_database.postgresql_db.resource_group_id", + "ibm_iam_authorization_policy.kms_policy.description", "ibm_iam_authorization_policy.kms_policy.source_resource_group_id" ], "pos": { @@ -489,7 +490,7 @@ }, "pos": { "filename": "main.tf", - "line": 49 + "line": 50 } }, "ibm_iam_authorization_policy.kms_policy": { @@ -498,6 +499,7 @@ "name": "kms_policy", "attributes": { "count": "kms_encryption_enabled", + "description": "resource_group_id", "source_resource_group_id": "resource_group_id", "target_resource_instance_id": "existing_kms_instance_guid" }, @@ -521,7 +523,7 @@ }, "pos": { "filename": "main.tf", - "line": 189 + "line": 190 } }, "ibm_resource_tag.postgresql_tag": { @@ -537,7 +539,7 @@ }, "pos": { "filename": "main.tf", - "line": 140 + "line": 141 } }, "time_sleep.wait_for_authorization_policy": { @@ -549,7 +551,7 @@ }, "pos": { "filename": "main.tf", - "line": 42 + "line": 43 } } }, @@ -569,7 +571,7 @@ }, "pos": { "filename": "main.tf", - "line": 217 + "line": 218 } } }, @@ -648,7 +650,7 @@ }, "pos": { "filename": "main.tf", - "line": 150 + "line": 151 } } } From 84a5710c96291315604779cc3333a8b6b0e8466d Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Mon, 4 Sep 2023 22:09:03 +0530 Subject: [PATCH 2/3] SKIP UPGRADE TEST --- main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.tf b/main.tf index c358e01e..06b9b59f 100644 --- a/main.tf +++ b/main.tf @@ -36,7 +36,7 @@ resource "ibm_iam_authorization_policy" "kms_policy" { target_service_name = local.kms_service target_resource_instance_id = var.existing_kms_instance_guid roles = ["Reader"] - description = "Allow all ICD Postgres instances in the resource group ${var.resource_group_id} to read from the ${local.kms_service} instance GUID ${var.existing_kms_instance_guid}" + description = "Allow all ICD Postgres instances in the resource group ${var.resource_group_id} to read from the ${local.kms_service} instance GUID ${var.existing_kms_instance_guid} " } # workaround for https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4478 From cecc24e73c2f4e56fe67fe9cd2406fb5120dd3d8 Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Tue, 5 Sep 2023 11:47:17 +0530 Subject: [PATCH 3/3] SKIP UPGRADE TEST --- main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.tf b/main.tf index 06b9b59f..c358e01e 100644 --- a/main.tf +++ b/main.tf @@ -36,7 +36,7 @@ resource "ibm_iam_authorization_policy" "kms_policy" { target_service_name = local.kms_service target_resource_instance_id = var.existing_kms_instance_guid roles = ["Reader"] - description = "Allow all ICD Postgres instances in the resource group ${var.resource_group_id} to read from the ${local.kms_service} instance GUID ${var.existing_kms_instance_guid} " + description = "Allow all ICD Postgres instances in the resource group ${var.resource_group_id} to read from the ${local.kms_service} instance GUID ${var.existing_kms_instance_guid}" } # workaround for https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4478