Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tflint: Add WalkResourceBlocks API #29

Merged
merged 1 commit into from
Jun 13, 2020
Merged

tflint: Add WalkResourceBlocks API #29

merged 1 commit into from
Jun 13, 2020

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Jun 9, 2020

See also #24

Similar to the expression, by transferring the body of the block in a text representation, we can pass the hcl.Block via RPC 🎉

The missing piece is json's Parse function that allows you to specify the starting position. I've already confirmed that HCL can do that, but I'm worried about how to merge it into the core as it will be a backward-incompatible API change. wata727/hcl@cf58d94

@wata727 wata727 force-pushed the text_transmission_over_rpc branch from 906c586 to 74f4303 Compare June 13, 2020 12:53
Base automatically changed from text_transmission_over_rpc to master June 13, 2020 12:59
@wata727 wata727 marked this pull request as ready for review June 13, 2020 13:45
@wata727
Copy link
Member Author

wata727 commented Jun 13, 2020

In favor of publishing, I have temporarily dropped support for JSON configuration syntax. I will open an issue later.

@wata727 wata727 merged commit 8f8f107 into master Jun 13, 2020
@wata727 wata727 deleted the add_block_walker_api branch June 13, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant