Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ECR image scanning #10656

Closed
tomelliff opened this issue Oct 28, 2019 · 5 comments 路 Fixed by #10671
Closed

Add support for ECR image scanning #10656

tomelliff opened this issue Oct 28, 2019 · 5 comments 路 Fixed by #10671

Comments

@tomelliff
Copy link
Contributor

@tomelliff tomelliff commented Oct 28, 2019

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

ECR repos now support image scanning. This support is in the v1.25.20 SDK.

New or Affected Resource(s)

  • aws_ecr_repository resource and data source

Potential Terraform Configuration

resource "aws_ecr_repository" "foo" {
  name = "bar"

  scan_on_push = true
}

References

https://aws.amazon.com/about-aws/whats-new/2019/10/announcing-image-scanning-for-amazon-ecr/

@ewbankkit

This comment has been minimized.

Copy link
Contributor

@ewbankkit ewbankkit commented Oct 28, 2019

@sergei-ivanov

This comment has been minimized.

Copy link
Contributor

@sergei-ivanov sergei-ivanov commented Oct 29, 2019

I already have a working implementation for that on my branch. Only need to update the tests and the docs, and a PR will be ready, as soon as the latest AWS SDK is merged into master.

@bflad bflad removed the needs-triage label Oct 29, 2019
@bflad

This comment has been minimized.

Copy link
Contributor

@bflad bflad commented Oct 29, 2019

Just merged in AWS Go SDK v1.25.21, hope this helps.

@bflad

This comment has been minimized.

Copy link
Contributor

@bflad bflad commented Oct 31, 2019

Support for the below has been merged and will release with version 2.34.0 of the Terraform AWS Provider, tomorrow. Thanks to @sergei-ivanov for the quick implementation 馃憤

resource "aws_ecr_repository" "example" {
  # ... other configuration

  image_scanning_configuration {
    scan_on_push = true # or false :)
  }
}
@bflad

This comment has been minimized.

Copy link
Contributor

@bflad bflad commented Oct 31, 2019

This has been released in version 2.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.