Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_route should validate which type of gateway is passed #9445

Open
jen20 opened this issue Jul 23, 2019 · 1 comment

Comments

@jen20
Copy link
Contributor

@jen20 jen20 commented Jul 23, 2019

The aws_route resource has a number of *_gateway_id properties which are documented as reflecting the AWS API for the type of gateway to which a route is being constructed. For example, an Internet Gateway is supposed to use gateway_id, and a NAT gateway is supposed to use nat_gateway_id. In a quirk of the AWS API, you can set a NAT gateway in gateway_id, but it is returned in nat_gateway_id, leaving a perpetual diff, but a valid route being created at the provider.

A way to fix this is to validate the prefixes of the various types of gateway being passed to each option. I'll open a pull request for this shortly.

@jen20

This comment has been minimized.

Copy link
Contributor Author

@jen20 jen20 commented Jul 23, 2019

Just realised the behaviour here is a duplicate of #158, but I'll leave this since it proposes a concrete fix to the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.