Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

First AWS Personalize resource: aws_personalize_dataset_group #10683

Open
wants to merge 6 commits into
base: master
from

Conversation

@gh-mlfowler
Copy link
Contributor

gh-mlfowler commented Oct 30, 2019

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

New Resource: `aws_personalize_dataset_group`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccPersonalize'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccPersonalize -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccPersonalizeDatasetGroup_basic
=== PAUSE TestAccPersonalizeDatasetGroup_basic
=== RUN   TestAccPersonalizeDatasetGroup_kms
=== PAUSE TestAccPersonalizeDatasetGroup_kms
=== CONT  TestAccPersonalizeDatasetGroup_basic
=== CONT  TestAccPersonalizeDatasetGroup_kms
--- PASS: TestAccPersonalizeDatasetGroup_basic (33.65s)
--- PASS: TestAccPersonalizeDatasetGroup_kms (104.56s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       104.611s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.053s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.049s [no tests to run]
...
gh-mlfowler added 6 commits Oct 21, 2019
Create, Read, Delete & Import, there is no update in the API.
Both attributes are required if either are specified
@gh-mlfowler gh-mlfowler requested a review from terraform-providers/aws-provider as a code owner Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.