New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update zclconf/go-cty to make GetSchema API work correctly #3456

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
2 participants
@minamijoyo
Contributor

minamijoyo commented Feb 20, 2018

I'm writing a third-party tool named tfschema (https://github.com/minamijoyo/tfschema), which gets resource type definitions dynamically from Terraform providers via go-plugin protocol.
The tfschema depends on the Terraform's GetSchema API, and currently does not work well with terraform-provider-aws.

The GetSchema API was introduced in Terraform v0.10.8 (hashicorp/terraform#16352), and its initial implementation had a bug related to decoding the gob encoded response from a provider (hashicorp/terraform#16423 (comment)).

This bug was fixed in Terraform v0.11.3 (hashicorp/terraform#17055).

The terraform version of the current terraform-provider-aws has been updated to v0.11.3 (#3228), however the version of go-cty remains old.

This pull request updates go-cty to the version 709e4033eeb037dc543dbc2048065dfb814ce316 used by terraform v0.11.3.
The go-cty master branch has additional commits, but I think that it is reasonable to make it the same as the version used by terraform v0.11.3.
If this pull request is merged, we can call the GetSchema API correctly!

$ govendor fetch github.com/zclconf/go-cty/...@709e4033eeb037dc543dbc2048065dfb814ce316
@minamijoyo

This comment has been minimized.

Contributor

minamijoyo commented Mar 6, 2018

@bflad Would you mind taking a little time to review this?

@bflad bflad added this to the v1.11.0 milestone Mar 6, 2018

@bflad

bflad approved these changes Mar 6, 2018

LGTM -- thanks!

@bflad bflad merged commit ad577ca into terraform-providers:master Mar 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minamijoyo

This comment has been minimized.

Contributor

minamijoyo commented Mar 6, 2018

@bflad Many Thanks!!

@bflad

This comment has been minimized.

Contributor

bflad commented Mar 9, 2018

This has been released in version 1.11.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment