Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add support for deprecate aws ssm maintenance window task #7823

Conversation

Projects
None yet
2 participants
@kterada0509
Copy link
Contributor

commented Mar 6, 2019

Fixes #7746, #7154

Changes proposed in this pull request:

  • Fix to use GetMaintenanceWindowTask method when read resource
  • Add Support Update resource
  • Fix to not return error when resource is already deleted
  • Add support import exist resource
  • Add attribute task_invocation_parameters
  • Add deprecated message for logging_info and task_parameters
  • Add test case for automation_parameters
  • Add test case for lambda_parameters
  • Add test case for run_command_parameters
  • Add test case for step_functions_parameters
  • Update document

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMMaintenanceWindowTask_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSSMMaintenanceWindowTask_ -timeout 120m
=== RUN   TestAccAWSSSMMaintenanceWindowTask_basic
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_basic
=== RUN   TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
=== RUN   TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters
=== RUN   TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters
=== RUN   TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters
=== RUN   TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters
=== CONT  TestAccAWSSSMMaintenanceWindowTask_basic
=== CONT  TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters
=== CONT  TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters
=== CONT  TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters
=== CONT  TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters
=== CONT  TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (147.07s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (163.38s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (169.52s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (173.94s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (204.06s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (232.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	232.506s

@kterada0509 kterada0509 force-pushed the kterada0509:feature/add-support-for-deprecate-aws_ssm_maintenance_window_task branch from ef3c95b to 08fe093 Mar 6, 2019

@kterada0509 kterada0509 force-pushed the kterada0509:feature/add-support-for-deprecate-aws_ssm_maintenance_window_task branch from 08fe093 to e0ab932 Mar 7, 2019

@hashibot hashibot bot added size/XXL and removed size/XL labels Mar 7, 2019

@kterada0509 kterada0509 changed the title [WIP] Feature/add support for deprecate aws ssm maintenance window task Feature/add support for deprecate aws ssm maintenance window task Mar 7, 2019

@kterada0509 kterada0509 marked this pull request as ready for review Mar 7, 2019

@e-moshaya

This comment has been minimized.

Copy link

commented Apr 3, 2019

any update on this PR when will this get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.