Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kinesis video service modules #8278

Conversation

Projects
None yet
2 participants
@kterada0509
Copy link
Contributor

commented Apr 11, 2019

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

References #2994

Changes proposed in this pull request:

  • Add aws-sdk-go kinesisvideo service
  • Add setting for kinesisvideo service

Output from acceptance testing:

Nothing
@@ -910,6 +910,7 @@ func init() {
"kinesis_analytics",
"kinesis",
"kinesisanalytics",
"kinesisvideo",

This comment has been minimized.

Copy link
@bflad

bflad Apr 11, 2019

Member

Can you please also add this to the available customizable service names in website/docs/guides/custom-service-endpoints.html.md? Thanks so much.

The CONTRIBUTING documentation surrounding this should be available soon: https://github.com/terraform-providers/terraform-provider-aws/pull/8277/files#diff-8cc7b2b0d78dd2501610391c086a8516R288

This comment has been minimized.

Copy link
@kterada0509

kterada0509 Apr 12, 2019

Author Contributor

@bflad Thanks. Fixed it.

@hashibot hashibot bot added the documentation label Apr 12, 2019

@bflad

bflad approved these changes Apr 12, 2019

Copy link
Member

left a comment

LGTM, thanks for the update @kterada0509 馃殌

@bflad bflad added this to the v2.7.0 milestone Apr 12, 2019

@bflad bflad merged commit f122a4a into terraform-providers:master Apr 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.