Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource - azurerm_cdn_endpoint_custom_domain (http only) #12496

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jul 7, 2021

New resource: azurerm_cdn_endpoint_custom_domain (http only).

There are still something needs figure out for https cases, but want to unblock some users don't need https feature first (as #398
has been opened long ago).

Test Result

💤 make testacc TEST=./azurerm/internal/services/cdn TESTARGS='-run="TestAccCdnEndpointCustomDomain_"' TESTTIMEOUT=48h
==> Checking that code complies with gofmt requirements...                                                                                                                                          ==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...                                                                                                                                              TF_ACC=1 go test ./azurerm/internal/services/cdn -v -run="TestAccCdnEndpointCustomDomain_" -timeout 48h -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"                                                                                                                                                                                             === RUN   TestAccCdnEndpointCustomDomain_basic                                                                                                                                                      === PAUSE TestAccCdnEndpointCustomDomain_basic
=== RUN   TestAccCdnEndpointCustomDomain_requiresImport                                                                                                                                             === PAUSE TestAccCdnEndpointCustomDomain_requiresImport
=== CONT  TestAccCdnEndpointCustomDomain_basic                                                                                                                                                      === CONT  TestAccCdnEndpointCustomDomain_requiresImport                                                                                                                                             --- PASS: TestAccCdnEndpointCustomDomain_basic (776.07s)
--- PASS: TestAccCdnEndpointCustomDomain_requiresImport (807.76s)                                                                                                                                   PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cdn 807.812s   

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - LGTM 🙌

@katbyte katbyte added this to the v2.71.0 milestone Jul 30, 2021
@katbyte katbyte merged commit 654521a into hashicorp:master Jul 30, 2021
katbyte added a commit that referenced this pull request Jul 30, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants