Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: azurerm_storage_share #12693

Merged
merged 8 commits into from Jul 29, 2021
Merged

New Data Source: azurerm_storage_share #12693

merged 8 commits into from Jul 29, 2021

Conversation

zhcli
Copy link
Contributor

@zhcli zhcli commented Jul 22, 2021

re #4931

tombuildsstuff
tombuildsstuff requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @zhcli

Thanks for this PR - apologies for the delayed review here.

I've taken a look through and this mostly LGTM, if we can fix up the issues I've flagged then this should otherwise be good to merge 👍

Thanks!

azurerm/internal/services/storage/storage_share_data_source.go Outdated Show resolved Hide resolved
azurerm/internal/services/storage/storage_share_data_source.go Outdated Show resolved Hide resolved
azurerm/internal/services/storage/storage_share_data_source.go Outdated Show resolved Hide resolved
zhcli and others added 3 commits July 26, 2021 23:01
@zhcli @tombuildsstuff
Update azurerm/internal/services/storage/storage_share_data_source.go
f02ab71 
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@zhcli @tombuildsstuff
Update azurerm/internal/services/storage/storage_share_data_source.go
1d6a3bd 
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@zhcli @tombuildsstuff
Update azurerm/internal/services/storage/storage_share_data_source.go
12f218f 
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@zhcli
Copy link
Contributor Author

zhcli commented Jul 26, 2021

@tombuildsstuff thanks for the tips!

@tombuildsstuff tombuildsstuff changed the title Feature: data source azurerm storage share New Data Source: azurerm_storage_share Jul 26, 2021
@tombuildsstuff tombuildsstuff added this to the v2.70.0 milestone Jul 26, 2021
@zhcli
Copy link
Contributor Author

zhcli commented Jul 29, 2021

@tombuildsstuff FYI - I ran golangci-lint locally on the same commit, it passed

katbyte
katbyte approved these changes Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnks @zhcli - LGTM 🚀

@katbyte katbyte merged commit 4918330 into hashicorp:master Jul 29, 2021
katbyte added a commit that referenced this pull request Jul 29, 2021
@katbyte
CHANGELOG.md for #12693
373ac5a
@katbyte katbyte mentioned this pull request Jul 29, 2021
Closed
@github-actions
Copy link

This functionality has been released in v2.70.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
documentation new-data-source service/storage size/L
Projects
None yet
Milestone
v2.70.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhcli @tombuildsstuff @katbyte