New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource & Data Source: `azurerm_snapshot` #420

Merged
merged 3 commits into from Oct 12, 2017

Conversation

Projects
None yet
2 participants
@tombuildsstuff
Contributor

tombuildsstuff commented Oct 12, 2017

  • New Resource: azurerm_snapshot
  • New Data Source: azurerm_snapshot
  • Re-organising all the Compute resources into a Compute section in the sidebar
@tombuildsstuff

This comment has been minimized.

Show comment
Hide comment
@tombuildsstuff

tombuildsstuff Oct 12, 2017

Contributor

Resource tests pass:

screen shot 2017-10-12 at 14 27 25

Contributor

tombuildsstuff commented Oct 12, 2017

Resource tests pass:

screen shot 2017-10-12 at 14 27 25

@tombuildsstuff tombuildsstuff requested a review from mbfrahry Oct 12, 2017

@tombuildsstuff

This comment has been minimized.

Show comment
Hide comment
@tombuildsstuff

tombuildsstuff Oct 12, 2017

Contributor

Snapshot Data Source tests pass:

screen shot 2017-10-12 at 16 04 18

Contributor

tombuildsstuff commented Oct 12, 2017

Snapshot Data Source tests pass:

screen shot 2017-10-12 at 16 04 18

@tombuildsstuff tombuildsstuff changed the title from New Resource: `azurerm_snapshot` to New Resource & Data Source: `azurerm_snapshot` Oct 12, 2017

@mbfrahry

LGTM! Just a question

* `create_option` - (Required) Indicates how the snapshot is to be created. Possible values are `Copy` or `Import`. Changing this forces a new resource to be created.
~> **Note:** One of `source_uri`, `source_resource_id` or `storage_account_id` must be specified.

This comment has been minimized.

@mbfrahry

mbfrahry Oct 12, 2017

Contributor

Do these conflict with each other or can you have all of them specified?

@mbfrahry

mbfrahry Oct 12, 2017

Contributor

Do these conflict with each other or can you have all of them specified?

This comment has been minimized.

@tombuildsstuff

tombuildsstuff Oct 12, 2017

Contributor

I assumed we'd be able to make these conflicting fields - but apparently you can have them all specified ¯_(ツ)_/¯

@tombuildsstuff

tombuildsstuff Oct 12, 2017

Contributor

I assumed we'd be able to make these conflicting fields - but apparently you can have them all specified ¯_(ツ)_/¯

This comment has been minimized.

@mbfrahry

mbfrahry Oct 12, 2017

Contributor

That's weird but alright let's ship it!

@mbfrahry

mbfrahry Oct 12, 2017

Contributor

That's weird but alright let's ship it!

@tombuildsstuff tombuildsstuff merged commit a8d12b8 into master Oct 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tombuildsstuff tombuildsstuff deleted the snapshot branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment