Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/postgresql_server: support storage auto-grow #4220

Merged

Conversation

@evenh
Copy link
Contributor

evenh commented Sep 3, 2019

Add support for Azure PostgreSQL storage auto-grow. It went into GA on
June 26th 2019.

It is enabled by default, to conform with the behaviour described in
the Azure CLI docs .

This resolves #3885

Add support for Azure PostgreSQL storage auto-grow. It went into GA on
June 26th 2019.

It is enabled by default, to conform with the behaviour described in
the Azure CLI docs .

This resolves #3885
Copy link
Contributor

tombuildsstuff left a comment

hey @evenh

Thanks for this PR - taking a look I've left a couple of comments inline but this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_postgresql_server.go Outdated Show resolved Hide resolved
azurerm/resource_arm_postgresql_server.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v1.34.0 milestone Sep 3, 2019
@evenh

This comment has been minimized.

Copy link
Contributor Author

evenh commented Sep 3, 2019

Thanks for the quick review @tombuildsstuff. Should be fixed now :-)

@hashibot hashibot bot removed the waiting-response label Sep 3, 2019
@tombuildsstuff

This comment has been minimized.

Copy link
Contributor

tombuildsstuff commented Sep 3, 2019

Tests pass:

Screenshot 2019-09-03 at 14 31 36

(ignore the Travis error, this is because Apache's Git server is down)

@tombuildsstuff tombuildsstuff merged commit be7690f into terraform-providers:master Sep 3, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
tombuildsstuff added a commit that referenced this pull request Sep 3, 2019
@hashibot

This comment has been minimized.

Copy link

hashibot bot commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...
@hashibot

This comment has been minimized.

Copy link

hashibot bot commented Oct 3, 2019

I'm going to lock this issue because it has been closed for 30 days . This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashibot hashibot bot locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.