Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS: Support outbound IPs when using standard loadbalancer #4472

Closed
wants to merge 1 commit into from

Conversation

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Oct 1, 2019

Re-basing #4400 - originally by @evenh

Fixes #4322

@katbyte
katbyte approved these changes Oct 8, 2019
Copy link
Contributor

katbyte left a comment

LGTM 👍

Copy link
Contributor

katbyte left a comment

tests fail:
image

@evenh

This comment has been minimized.

Copy link
Contributor

evenh commented Oct 10, 2019

We need this functionality urgently. Is there anything we can do to help out @tombuildsstuff?

@Bowbaq

This comment has been minimized.

Copy link
Contributor

Bowbaq commented Oct 10, 2019

I'd also really like this. Here's the workaround I have in the meantime:

data "azurerm_resource_group" "this" {
  ...
}

resource "azurerm_public_ip" "cluster" {
  ...
}

resource "azurerm_kubernetes_cluster" "this" {
  ...

  # Temporary hack until https://github.com/terraform-providers/terraform-provider-azurerm/issues/4322 is fixed
  provisioner "local-exec" {
    interpreter = ["bash", "-c"]
    command     = <<EOF
      if [ -z "$(az extension list | jq -r '.[] | select(.name == "aks-preview")')" ]; then
        az extension add -n aks-preview -y
      else
        az extension update -n aks-preview || true
      fi

      az aks update \
        --resource-group ${data.azurerm_resource_group.this.name} \
        --name ${self.name} \
        --load-balancer-outbound-ips ${azurerm_public_ip.cluster.id}
EOF
  }
}
@landro

This comment has been minimized.

Copy link

landro commented Oct 14, 2019

Hi @tombuildsstuff , any chance we can have this feature merged any time soon?

@landro

This comment has been minimized.

Copy link

landro commented Oct 24, 2019

Hi @tombuildsstuff - is there anything we can do to help move this PR forward?

@tombuildsstuff tombuildsstuff modified the milestones: v1.36.0, v1.37.0 Oct 28, 2019
@ekarlso

This comment has been minimized.

Copy link

ekarlso commented Nov 1, 2019

@tombuildsstuff can we get this expedited for a release soon? We're having fun with duplicate ips on all our clusters that has Standard SKU.

Copy link
Contributor

katbyte left a comment

LGTM 👍

@tombuildsstuff tombuildsstuff force-pushed the outbound-IPs branch from 37a5044 to 1c778f9 Nov 18, 2019
@tombuildsstuff tombuildsstuff removed this from the v1.37.0 milestone Nov 21, 2019
@tombuildsstuff tombuildsstuff added this to the v1.38.0 milestone Nov 21, 2019
@seboss666

This comment has been minimized.

Copy link

seboss666 commented Nov 27, 2019

Hello,
I've just ran into the problem of "duplicate IP" when switching to standard LB SKU (to activate API Server authorized IP ranges . Any update on conflict resolution ?

@tombuildsstuff tombuildsstuff modified the milestones: v1.38.0, v1.39.0 Nov 28, 2019
@ekarlso

This comment has been minimized.

Copy link

ekarlso commented Dec 5, 2019

@tombuildsstuff any idea on this?

@tombuildsstuff tombuildsstuff modified the milestones: v1.39.0, v1.40.0 Dec 11, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.40.0, v1.41.0 Dec 18, 2019
@landro

This comment has been minimized.

Copy link

landro commented Jan 10, 2020

Hi @tombuildsstuff !
this PR has been pushed from milestone to milestone for the past few months. Do you think it will make it this time? Is there anything we can do to help out?

@tombuildsstuff tombuildsstuff removed this from the v1.41.0 milestone Jan 10, 2020
@tombuildsstuff

This comment has been minimized.

Copy link
Contributor Author

tombuildsstuff commented Jan 10, 2020

@landro unfortunately this isn't something we've got time to rebase at the moment - we're hoping that we can come back to this once the remaining bits of 2.0 have come together.

From our side if someone has time to rebase/fix this up/send a new PR we're more than happy to close this PR in favour of another one - however I don't believe we're going to get a chance to do this in the next couple of weeks unfortunately.

@rubbish

This comment has been minimized.

Copy link
Contributor

rubbish commented Jan 15, 2020

just as an FYI, @evenh has rebased this into a new PR: #5394

@katbyte

This comment has been minimized.

Copy link
Contributor

katbyte commented Jan 15, 2020

thanks @rubbish, closing in favour of #5394.

@katbyte katbyte closed this Jan 15, 2020
@tombuildsstuff tombuildsstuff deleted the outbound-IPs branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

8 participants
You can’t perform that action at this time.