Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min_capacity and max_capacity of application gateway #4958

Merged

Conversation

@pallxk
Copy link
Contributor

pallxk commented Nov 22, 2019

I've tested the numbers with Azure Portal Create an Application Gateway, Azure Portal Application Gateway Edit Configuration, and referenced the docs and errors given back while fiddling.

The actual allowed min_capacity is 0-100, inclusive;
The actual allowed max_capacity is 2-125, inclusive, plus the requirement that max_capacity > min_capacity.

Reference doc:
https://docs.microsoft.com/en-US/azure/application-gateway/application-gateway-autoscaling-zone-redundant#scaling-application-gateway-and-waf-v2

Fix #4722.

Copy link
Contributor

tombuildsstuff left a comment

LGTM - thanks for this @pallxk

@tombuildsstuff

This comment has been minimized.

Copy link
Contributor

tombuildsstuff commented Nov 28, 2019

Tests pass:

Screenshot 2019-11-28 at 15 45 40

@tombuildsstuff tombuildsstuff merged commit d96c892 into terraform-providers:master Nov 28, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tombuildsstuff added a commit that referenced this pull request Nov 28, 2019
@hashibot

This comment has been minimized.

Copy link

hashibot bot commented Dec 7, 2019

This has been released in version 1.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.38.0"
}
# ... other configuration ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.