New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance Test Fixes #546

Merged
merged 4 commits into from Nov 10, 2017

Conversation

Projects
None yet
2 participants
@tombuildsstuff
Contributor

tombuildsstuff commented Nov 10, 2017

Working through the broken acceptance tests:

  • Fixing some broken tests where Route was made Computed again
  • Fixing an intermittent issue where the ServiceBus namespace was deleted but was returned as an error

tombuildsstuff added some commits Nov 10, 2017

Fixing the `TestAccAzureRMRouteTable_removeRoute` test:
```
$ acctests azurerm TestAccAzureRMRouteTable_removeRoute
=== RUN   TestAccAzureRMRouteTable_removeRoute
--- PASS: TestAccAzureRMRouteTable_removeRoute (97.31s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    97.337s
```
Route's been made Computed again, this fixes the tests:
before:

```
------- Stdout: -------
=== RUN   TestAccAzureRMRoute_basic
--- FAIL: TestAccAzureRMRoute_basic (103.26s)
    testing.go:459: Step 0 error: Expected a non-empty plan, but got an empty plan!
FAIL

------- Stdout: -------
=== RUN   TestAccAzureRMRoute_multipleRoutes
--- FAIL: TestAccAzureRMRoute_multipleRoutes (104.12s)
    testing.go:459: Step 0 error: Expected a non-empty plan, but got an empty plan!
FAIL
```

after now:

```
$ acctests azurerm TestAccAzureRMRoute_basic
=== RUN   TestAccAzureRMRoute_basic
--- PASS: TestAccAzureRMRoute_basic (105.66s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    105.682s

$ acctests azurerm TestAccAzureRMRoute_multipleRoutes
=== RUN   TestAccAzureRMRoute_multipleRoutes
--- PASS: TestAccAzureRMRoute_multipleRoutes (130.54s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    130.578s
```
Fixing an intermittent issue where the servicebus namespace would ret…
…urn:

```
------- Stdout: -------
=== RUN   TestAccAzureRMServiceBusTopic_enablePartitioningPremium
--- FAIL: TestAccAzureRMServiceBusTopic_enablePartitioningPremium (206.43s)
    testing.go:459: Step 1 error: Error applying: 1 error(s) occurred:

        * azurerm_servicebus_namespace.test (destroy): 1 error(s) occurred:

        * azurerm_servicebus_namespace.test: Error issuing Azure ARM delete request of ServiceBus Namespace 'acctestservicebusnamespace-4196038718262348607': <nil>
FAIL
```
@tombuildsstuff

This comment has been minimized.

Show comment
Hide comment
@tombuildsstuff

tombuildsstuff Nov 10, 2017

Contributor

Route Tests before:

------- Stdout: -------
=== RUN   TestAccAzureRMRoute_basic
--- FAIL: TestAccAzureRMRoute_basic (103.26s)
    testing.go:459: Step 0 error: Expected a non-empty plan, but got an empty plan!
FAIL

------- Stdout: -------
=== RUN   TestAccAzureRMRoute_multipleRoutes
--- FAIL: TestAccAzureRMRoute_multipleRoutes (104.12s)
    testing.go:459: Step 0 error: Expected a non-empty plan, but got an empty plan!
FAIL

after this PR:

$ acctests azurerm TestAccAzureRMRoute_basic
=== RUN   TestAccAzureRMRoute_basic
--- PASS: TestAccAzureRMRoute_basic (105.66s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    105.682s

$ acctests azurerm TestAccAzureRMRoute_multipleRoutes
=== RUN   TestAccAzureRMRoute_multipleRoutes
--- PASS: TestAccAzureRMRoute_multipleRoutes (130.54s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    130.578s
Contributor

tombuildsstuff commented Nov 10, 2017

Route Tests before:

------- Stdout: -------
=== RUN   TestAccAzureRMRoute_basic
--- FAIL: TestAccAzureRMRoute_basic (103.26s)
    testing.go:459: Step 0 error: Expected a non-empty plan, but got an empty plan!
FAIL

------- Stdout: -------
=== RUN   TestAccAzureRMRoute_multipleRoutes
--- FAIL: TestAccAzureRMRoute_multipleRoutes (104.12s)
    testing.go:459: Step 0 error: Expected a non-empty plan, but got an empty plan!
FAIL

after this PR:

$ acctests azurerm TestAccAzureRMRoute_basic
=== RUN   TestAccAzureRMRoute_basic
--- PASS: TestAccAzureRMRoute_basic (105.66s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    105.682s

$ acctests azurerm TestAccAzureRMRoute_multipleRoutes
=== RUN   TestAccAzureRMRoute_multipleRoutes
--- PASS: TestAccAzureRMRoute_multipleRoutes (130.54s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    130.578s
Fixing the broken `TestAccAzureRMServiceBusTopic_enablePartitioningPr…
…emium` test:

```
$ acctests azurerm TestAccAzureRMServiceBusTopic_enablePartitioningPremium
=== RUN   TestAccAzureRMServiceBusTopic_enablePartitioningPremium
--- PASS: TestAccAzureRMServiceBusTopic_enablePartitioningPremium (504.31s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    504.341s
```
@tombuildsstuff

This comment has been minimized.

Show comment
Hide comment
@tombuildsstuff

tombuildsstuff Nov 10, 2017

Contributor

Service Bus Tests:

screen shot 2017-11-10 at 13 48 19

Contributor

tombuildsstuff commented Nov 10, 2017

Service Bus Tests:

screen shot 2017-11-10 at 13 48 19

@mbfrahry

LGTM

@tombuildsstuff tombuildsstuff merged commit 5bc8df7 into master Nov 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tombuildsstuff tombuildsstuff deleted the fixing-broken-tests branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment