New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to v12.2.0-beta of the Azure SDK for Go #684

Merged
merged 3 commits into from Jan 12, 2018

Conversation

Projects
None yet
3 participants
@tombuildsstuff
Contributor

tombuildsstuff commented Jan 11, 2018

This is the first phase of upgrading to the Azure SDK for Go v12.2.0-beta. Once this is merged we can start moving Data Sources and Resources off the Deprecated SDKs and over to the versioned SDKs

Upgrades to:

@tombuildsstuff tombuildsstuff requested a review from mbfrahry Jan 11, 2018

@tombuildsstuff tombuildsstuff changed the title from [WIP] Upgrading to v12.2.0-beta of the Azure SDK for Go to Upgrading to v12.2.0-beta of the Azure SDK for Go Jan 11, 2018

@mbfrahry

LGTM!

@tombuildsstuff tombuildsstuff added this to the 1.0.2 milestone Jan 12, 2018

@dominik-lekse

This comment has been minimized.

Show comment
Hide comment
@dominik-lekse

dominik-lekse Jan 12, 2018

Contributor

That was quick, thanks for the upgrade.

Contributor

dominik-lekse commented Jan 12, 2018

That was quick, thanks for the upgrade.

@tombuildsstuff

This comment has been minimized.

Show comment
Hide comment
@tombuildsstuff

tombuildsstuff Jan 12, 2018

Contributor

@dominik-lekse alas this is only the first part - once this PR is merged I'll switch over to the versioned (e.g. not deprecated) SDK and then we should be good :)

Contributor

tombuildsstuff commented Jan 12, 2018

@dominik-lekse alas this is only the first part - once this PR is merged I'll switch over to the versioned (e.g. not deprecated) SDK and then we should be good :)

@dominik-lekse

This comment has been minimized.

Show comment
Hide comment
@dominik-lekse

dominik-lekse Jan 12, 2018

Contributor

As far as I understood, the switch over to the versioned part of the SDK will be done per resource, right?

Contributor

dominik-lekse commented Jan 12, 2018

As far as I understood, the switch over to the versioned part of the SDK will be done per resource, right?

@tombuildsstuff

This comment has been minimized.

Show comment
Hide comment
@tombuildsstuff

tombuildsstuff Jan 12, 2018

Contributor

Tests look good - so I'm going to merge this to continue with part 2

@dominik-lekse probably, given the arm folder in the SDK gets removed next month I'm wondering if it's prudent just to do it in a few batches (I'll try migrating a few over and see how invasive it is - it may be prudent just to do it in one sweep, although that's less ideal for review reasons)

Contributor

tombuildsstuff commented Jan 12, 2018

Tests look good - so I'm going to merge this to continue with part 2

@dominik-lekse probably, given the arm folder in the SDK gets removed next month I'm wondering if it's prudent just to do it in a few batches (I'll try migrating a few over and see how invasive it is - it may be prudent just to do it in one sweep, although that's less ideal for review reasons)

@tombuildsstuff tombuildsstuff merged commit 0437d99 into master Jan 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tombuildsstuff tombuildsstuff deleted the azure-sdk-v12 branch Jan 12, 2018

tombuildsstuff added a commit that referenced this pull request Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment