Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_user fix test complete #7866

Merged
merged 2 commits into from Jul 24, 2020

Conversation

yupwei68
Copy link
Contributor

=== RUN TestAccAzureRMApiManagementUser_complete
=== PAUSE TestAccAzureRMApiManagementUser_complete
=== CONT TestAccAzureRMApiManagementUser_complete
--- PASS: TestAccAzureRMApiManagementUser_complete (2521.63s)

@ghost ghost added the size/XS label Jul 23, 2020
@yupwei68 yupwei68 closed this Jul 23, 2020
@yupwei68 yupwei68 reopened this Jul 23, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but we'll want to update the timeout section in the docs with these new values

@ghost ghost added the documentation label Jul 24, 2020
@yupwei68
Copy link
Contributor Author

Sure. Thanks @mbfrahry for your comments. Please continue reviewing

@yupwei68 yupwei68 requested a review from mbfrahry July 24, 2020 02:38
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔨

@katbyte katbyte merged commit 8f8da95 into hashicorp:master Jul 24, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 2.21.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.21.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants