Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a droplet by tag #290

Conversation

@danramteke
Copy link
Contributor

commented Sep 2, 2019

The datasource for droplets currently only allows look up by name. Since DigitalOcean tags are so powerful, I thought it would be useful to look up a droplet by tag.

Because the datasource_digitalocean_droplet is meant for looking up only 1 droplet, if multiple droplets have the same tag, it is an error.

If neither name nor tag is specified as an argument, it is an error.

If both name and tag are specified, tag is the default lookup.

I have updated the documentation website as well.

In addition, I have updated the repo for Apache Thrift, as it does not build on a clean checkout. I have followed what another organization recently did: ory/hydra@8604797

Daniel
@eddiezane

This comment has been minimized.

Copy link
Collaborator

commented Sep 13, 2019

@danramteke thanks for the PR! @andrewsomething and I were at HashiConf this past week and will dive in to this next.

@hashibot hashibot bot added size/L and removed size/M labels Sep 25, 2019
@hashibot hashibot bot added size/XXL dependencies and removed size/L labels Sep 25, 2019
@andrewsomething

This comment has been minimized.

Copy link
Collaborator

commented Sep 25, 2019

Thanks so much for the contribution @danramteke! Apologies for the long review cycle.

I did make an additional change adding an acceptance test for this feature. See: 035f5fe

@andrewsomething andrewsomething merged commit e8548f4 into terraform-providers:master Sep 25, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@danramteke

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

Nice!

@danramteke danramteke deleted the danramteke:danramteke/datasource-droplet-by-tag branch Sep 26, 2019
@MattIPv4

This comment has been minimized.

Copy link

commented Sep 27, 2019

Hey, @danramteke - Thanks a ton for this sweet PR! 😄

Would you please shoot me an email when you get a chance?
mcowley at digitalocean dot com 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.