Generate resource_compute_firewall in magic-modules. I also decided to use PATCH instead of PUT for updates, because a lot of the fields we had marked as ForceNew can be updated with PATCH. #1907
Conversation
google/resource_compute_firewall.go
Outdated
| "target_tags": { | ||
| Type: schema.TypeSet, | ||
| Type: schema.TypeList, |
There was a problem hiding this comment.
should probably keep this as TypeSet
| }, | ||
|
|
||
| "source_ranges": { | ||
| "source_service_accounts": { |
There was a problem hiding this comment.
Do we want to keep the MaxItems: 1 validation for source/target_service_accounts? Can see arguments for either
There was a problem hiding this comment.
Oh good call, I missed that. I just checked and the API still errors, so I think we should keep it so it can be plan time. If the restrictions go away in the future, our users will probably tell us :P
I also decided to use PATCH instead of PUT for updates, because a lot of the fields we had marked as ForceNew can be updated with PATCH.
modular-magician
force-pushed
the
codegen-pr-405
branch
from
c52979a
to
8b09640
Compare
…o use PATCH instead of PUT for updates, because a lot of the fields we had marked as ForceNew can be updated with PATCH. (hashicorp#1907) <!-- This change is generated by MagicModules. --> /cc @danawillow
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
/cc @danawillow