Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCP zone to client_config datasource #3262

Merged

Conversation

Projects
None yet
2 participants
@mt-inside
Copy link
Contributor

commented Mar 17, 2019

The datasource google_client_config currently reads the region from the gcloud config (returning empty string if unset). I need to use the currently configured zone in a system I'm working on; this PR adds that.

@mt-inside mt-inside force-pushed the mt-inside:mt-add-client-config-zone branch from c002671 to 985afb0 Mar 18, 2019

@danawillow
Copy link
Collaborator

left a comment

Thanks @mt-inside!

@mt-inside

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

No problem!

@mt-inside mt-inside closed this May 6, 2019

@danawillow danawillow reopened this May 6, 2019

@danawillow danawillow merged commit 344c0a2 into terraform-providers:master May 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.