Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputeV2: add instance vendor_options #422

Merged

Conversation

@ozerovandrei
Copy link
Collaborator

commented Sep 17, 2018

Add "vendor_options" map attribute for instance with the
"ignore_resize_confirmation" option.

New option can be used to ignore manual confirmation of the Compute
instance resizing. Some OpenStack cloud providers automatically confirm
resizing of instances after configured timeout.

For #420

ComputeV2: add instance vendor_options
Add "vendor_options" map attribute for instance with the
"ignore_resize_confirmation" option.

New option can be used to ignore manual confirmation of the Compute
instance resizing. Some OpenStack cloud providers automatically confirm
resizing of instances after configured timeout.

@hashibot hashibot bot added the size/L label Sep 17, 2018

@ozerovandrei ozerovandrei self-assigned this Sep 17, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

commented Sep 17, 2018

Build succeeded.

@ozerovandrei ozerovandrei requested a review from jtopjian Sep 17, 2018

@jtopjian
Copy link
Contributor

left a comment

The implementation looks good, though I don't have an easy way of checking this.

Just needs a doc update (similar to https://github.com/terraform-providers/terraform-provider-openstack/blob/master/website/docs/r/networking_router_v2.html.markdown) and this is good to go.

ComputeV2: add vendor_options to instance docs
Add notes about Compute instance "vendor_options".

@hashibot hashibot bot added the size/L label Sep 18, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

commented Sep 18, 2018

Build succeeded.

@ozerovandrei

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 18, 2018

@jtopjian I added it.

I don't have an easy way of checking this.
Well, I checked it in on the Selectel VPC, it's OpenStack-based cloud and it has the resize_confirm_window configured to 10 seconds. So it's always causes errors for the terraform-provider-openstack users 😄

@jtopjian

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2018

Awesome - sounds good.

@jtopjian
Copy link
Contributor

left a comment

LGTM

@jtopjian jtopjian merged commit 61b3b67 into terraform-providers:master Sep 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
openlab/check check status: success
Details
@jtopjian

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2018

Oh duh - merged this by habit. Sorry about that.

@ozerovandrei

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 19, 2018

@jtopjian whatever, it was ready anyway 😄

@ozerovandrei ozerovandrei deleted the ozerovandrei:fix/compute-resize-verify branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.