Skip to content
This repository has been archived by the owner on Nov 14, 2020. It is now read-only.

Add resource to create tablespaces #94

Open
Hjdskes opened this issue Sep 1, 2019 · 3 comments
Open

Add resource to create tablespaces #94

Hjdskes opened this issue Sep 1, 2019 · 3 comments

Comments

@Hjdskes
Copy link
Contributor

Hjdskes commented Sep 1, 2019

Hi,

For a project we need the ability to create tablespaces. As far as we have found, there does not exist a resource yet that allows us to do this. Would you be open to accepting such a postgresql_tablespace resource? I'd be happy to write it myself, but I wanted to ensure you would accept this before I set off on doing this.

The idea is that this resource would run CREATE TABLESPACE ... OWNER ... LOCATION '...' after creating a role and before creating a database, such that postgresql_database.tablespace_name can be set to the created tablespace.

Terraform Version

 > terraform version
Terraform v0.12.7

Affected Resource(s)

  • none, perhaps the new postgresql_tablespace resource.
@cyrilgdn
Copy link
Contributor

Hi @Hjdskes ,

No problem if you want to create this new resource, I'd be happy to review and merge your PR 👍

@jgersdorf
Copy link

jgersdorf commented Aug 5, 2020

Hi,

I've also been looking for this - but after reading https://forums.aws.amazon.com/thread.jspa?threadID=301582 don't need it any more. At least on AWS RDS, you should not create your own tablespaces. So a postgresql_tablespace resource is not needed here.

Regards

Jens

@Hjdskes
Copy link
Contributor Author

Hjdskes commented Aug 5, 2020

At least on AWS RDS, you should not create your own tablespaces. So a postgresql_tablespace resource is not needed here.

Can you elaborate? We are doing exactly this and it has been working fine for us for the roughly one and a half years we've been doing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants