From 86f3716ed02fcf5b7d49a1be766f3886b461ba72 Mon Sep 17 00:00:00 2001
From: John Stilley <1831479+john-science@users.noreply.github.com>
Date: Tue, 29 Nov 2022 09:33:25 -0800
Subject: [PATCH] Removing unused Parameters (#997)

Removing the parameters:

* assemPeakStd
* cladDensity
* cladWorthDollarsPerKg
* coolantWorthDollarsPerKg
* corePow
* coupledIteration
* detailedDpaNewCycle
* detailedDpaPeakNewCycle
* directPertKeff
* dpaRx
* fuelRadialDisplacement
* fuelWorthDollarsPerKg
* hydDiam
* innerMatrixIndex
* regName
* structureDensity
* structureWorth
* structureWorthDollarsPerKg
---
 armi/physics/fuelPerformance/parameters.py |  6 ---
 armi/physics/neutronics/parameters.py      | 14 -------
 armi/reactor/blockParameters.py            | 48 ----------------------
 armi/reactor/reactorParameters.py          | 24 -----------
 4 files changed, 92 deletions(-)

diff --git a/armi/physics/fuelPerformance/parameters.py b/armi/physics/fuelPerformance/parameters.py
index 47e80937e..60438be4a 100644
--- a/armi/physics/fuelPerformance/parameters.py
+++ b/armi/physics/fuelPerformance/parameters.py
@@ -94,10 +94,4 @@ def _getFuelPerformanceBlockParams():
             default=0.0,
         )
 
-        pb.defParam(
-            "fuelRadialDisplacement",
-            units="cm",
-            description="Radial fuel displacement from irradiation",
-        )
-
     return pDefs
diff --git a/armi/physics/neutronics/parameters.py b/armi/physics/neutronics/parameters.py
index 4ba4f6a8f..3e322ee11 100644
--- a/armi/physics/neutronics/parameters.py
+++ b/armi/physics/neutronics/parameters.py
@@ -634,20 +634,6 @@ def linPowByPinGamma(self, value):
         pb.defParam("powerNeutron", units="W", description="Total neutron power")
 
     with pDefs.createBuilder(default=0.0) as pb:
-        pb.defParam(
-            "detailedDpaNewCycle",
-            units="dpa",
-            description="The total DPA accumulated in all burn steps of one cycle",
-            location=ParamLocation.AVERAGE,
-        )
-
-        pb.defParam(
-            "detailedDpaPeakNewCycle",
-            units="dpa",
-            description="The total peak DPA accumulated in all burn steps of one cycle",
-            location=ParamLocation.AVERAGE,
-        )
-
         pb.defParam(
             "detailedDpaThisCycle",
             units="dpa",
diff --git a/armi/reactor/blockParameters.py b/armi/reactor/blockParameters.py
index 4b3624382..7e64010f1 100644
--- a/armi/reactor/blockParameters.py
+++ b/armi/reactor/blockParameters.py
@@ -302,10 +302,6 @@ def buGroupNum(self, buGroupNum):  # pylint: disable=method-hidden
             "powerRx", units="W/cm$^3$", description="?", location=ParamLocation.AVERAGE
         )
 
-        pb.defParam(
-            "dpaRx", units="dpa/s", description="?", location=ParamLocation.AVERAGE
-        )
-
         pb.defParam(
             "heliumInB4C",
             units="He/s/cm$^3$",
@@ -337,8 +333,6 @@ def buGroupNum(self, buGroupNum):  # pylint: disable=method-hidden
 
         pb.defParam("basePBu", units="?", description="?", saveToDB=False)
 
-        pb.defParam("hydDiam", units="?", description="?", saveToDB=False)
-
         pb.defParam(
             "nHMAtBOL",
             units="atoms/bn-cm.",
@@ -439,14 +433,6 @@ def xsTypeNum(self, value):  # pylint: disable=method-hidden
             saveToDB=True,
         )
 
-        pb.defParam(
-            "regName",
-            units="?",
-            description="Set by Assembly in writeNIP30 once the region has been placed",
-            default=False,
-            saveToDB=False,
-        )
-
     with pDefs.createBuilder(
         default=0.0,
         location=ParamLocation.AVERAGE,
@@ -471,12 +457,6 @@ def xsTypeNum(self, value):  # pylint: disable=method-hidden
             description="Reactivity worth of fuel material per unit mass",
         )
 
-        pb.defParam(
-            "fuelWorthDollarsPerKg",
-            units="$/kg",
-            description="Reactivity worth of fuel material per unit mass",
-        )
-
         pb.defParam("fuelWorthPT", units="pcm/%/cm^3", description="Fuel reactivity")
 
         pb.defParam(
@@ -507,36 +487,12 @@ def xsTypeNum(self, value):  # pylint: disable=method-hidden
             description="Reactivity worth of coolant material per unit mass",
         )
 
-        pb.defParam(
-            "coolantWorthDollarsPerKg",
-            units="$/kg",
-            description="Reactivity worth of coolant material per unit mass",
-        )
-
         pb.defParam(
             "cladWorth",
             units="dk/kk'-kg",
             description="Reactivity worth of clad material per unit mass",
         )
 
-        pb.defParam(
-            "cladWorthDollarsPerKg",
-            units="$/kg",
-            description="Reactivity worth of clad material per unit mass",
-        )
-
-        pb.defParam(
-            "structureWorth",
-            units="dk/kk'-kg",
-            description="Reactivity worth of structure material per unit mass",
-        )
-
-        pb.defParam(
-            "structureWorthDollarsPerKg",
-            units="$/kg",
-            description="Reactivity worth of structure material (non-clad and non-wire wrap material) per unit mass",
-        )
-
         pb.defParam(
             "rxAxialCentsPerK",
             units="cents/K",
@@ -646,10 +602,6 @@ def xsTypeNum(self, value):  # pylint: disable=method-hidden
             description="Voided Doppler power reactivity coefficient",
         )
 
-        pb.defParam(
-            "assemPeakStd", units="pcm/%/cm^3", description="Spectral reactivity"
-        )
-
     with pDefs.createBuilder(
         default=0.0,
         location=ParamLocation.AVERAGE,
diff --git a/armi/reactor/reactorParameters.py b/armi/reactor/reactorParameters.py
index 437498b41..03d2b754a 100644
--- a/armi/reactor/reactorParameters.py
+++ b/armi/reactor/reactorParameters.py
@@ -216,12 +216,6 @@ def detailedNucKeys(self, value):
             "critSearchSlope", units=None, description="Critical keff search slope"
         )
 
-        pb.defParam(
-            "directPertKeff",
-            units=None,
-            description="K-eff is computed for the perturbed case with a direct calculation",
-        )
-
         pb.defParam(
             "doublingTime",
             units="EFPY",
@@ -234,12 +228,6 @@ def detailedNucKeys(self, value):
             "heavyMetalMass", units="g", description="Heavy Metal mass of the reactor"
         )
 
-        pb.defParam(
-            "innerMatrixIndex",
-            units=None,
-            description="The item index of the inner matrix in an optimization case",
-        )
-
         pb.defParam(
             "keffUnc",
             units=None,
@@ -504,16 +492,6 @@ def detailedNucKeys(self, value):
             description="Coolant temperature coefficient weighted to include bond and interstitial effects",
         )
 
-        pb.defParam(
-            "cladDensity", units="cents/K", description="Clad temperature coefficient"
-        )
-
-        pb.defParam(
-            "structureDensity",
-            units="cents/K",
-            description="Structure temperature coefficient",
-        )
-
         pb.defParam(
             "Voideddoppler", units="cents/K", description="Voided Doppler coefficient"
         )
@@ -770,8 +748,6 @@ def detailedNucKeys(self, value):
             default=0.0,
         )
 
-        pb.defParam("corePow", units="?", description="?")
-
         pb.defParam("coupledIteration", units="?", description="?", default=0)
 
         pb.defParam("fisFrac", units="?", description="?")