From ee49383ede75793ff73235e11a6178fa6cba289b Mon Sep 17 00:00:00 2001 From: John Stilley <1831479+john-science@users.noreply.github.com> Date: Tue, 20 Feb 2024 16:16:27 -0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Chris Keckler --- armi/reactor/grids/hexagonal.py | 8 ++++---- armi/utils/asciimaps.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/armi/reactor/grids/hexagonal.py b/armi/reactor/grids/hexagonal.py index debd98c74..f3cee9304 100644 --- a/armi/reactor/grids/hexagonal.py +++ b/armi/reactor/grids/hexagonal.py @@ -271,9 +271,9 @@ def _indicesAndEdgeFromRingAndPos(ring, position): Parameters ---------- - ring: int + ring : int Starting with 1 (not zero), the ring of the grid cell. - position: int + position : int Starting with 1 (not zero), the position of the grid cell, in the ring. Returns @@ -331,9 +331,9 @@ def getIndicesFromRingAndPos(ring: int, pos: int) -> IJType: Parameters ---------- - ring: int + ring : int Starting with 1 (not zero), the ring of the grid cell. - position: int + position : int Starting with 1 (not zero), the position of the grid cell, in the ring. Returns diff --git a/armi/utils/asciimaps.py b/armi/utils/asciimaps.py index 535225715..c62086117 100644 --- a/armi/utils/asciimaps.py +++ b/armi/utils/asciimaps.py @@ -419,7 +419,7 @@ def _makeOffsets(self): # renomalize the offsets to start at 0 minOffset = min(self.asciiOffsets) - for _li, (_, offset) in enumerate(zip(self.asciiLines, self.asciiOffsets)): + for offset in self.asciiOffsets: newOffsets.append(offset - minOffset) self.asciiOffsets = newOffsets