Skip to content

Support Content-Encoding header (compression) #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ethanaobrien opened this issue Mar 22, 2022 · 4 comments · Fixed by #78
Closed

Support Content-Encoding header (compression) #74

ethanaobrien opened this issue Mar 22, 2022 · 4 comments · Fixed by #78
Assignees
Labels
enhancement New feature or request

Comments

@ethanaobrien
Copy link
Collaborator

ethanaobrien commented Mar 22, 2022

Less data is transferred (send dependency will need to be removed first)

for gzip I have found this works

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding

@ethanaobrien ethanaobrien added the enhancement New feature or request label Mar 22, 2022
@terreng
Copy link
Owner

terreng commented Mar 22, 2022

This sounds great! Just make sure to check the Accept-Encoding request header to only use encoding with supported browsers.

@terreng
Copy link
Owner

terreng commented Apr 1, 2022

I've added the HTTP compression option to the UI and the documentation (and renamed the option to compression). I made a slight change to handlers.js.

Unfortunately, now that I am trying it out, I'm finding that it's unbearably slow. Even on my machine. Is there any way to speed this up? Otherwise I don't think we should ship this feature. Maybe once we are using Tauri and running a more native web server it'll perform better.

@terreng terreng reopened this Apr 1, 2022
@ethanaobrien
Copy link
Collaborator Author

Yeah it is really really slow, theres nothing we can do to speed it up. It's your choice whether we include this feature.

@terreng
Copy link
Owner

terreng commented Apr 1, 2022

I've removed the option from the UI and documentation, but it's still accessible by manually editing config.json. We can revisit this option later, but I'm closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants