From fbf396b1081b4e61a0961bc400be03d4163c5d95 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jorge=20Gab=C3=ADn?= Date: Thu, 2 May 2024 16:00:06 +0100 Subject: [PATCH] Update correction unit test --- tests/test_experiment.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/test_experiment.py b/tests/test_experiment.py index 2030d42d..5498ba30 100644 --- a/tests/test_experiment.py +++ b/tests/test_experiment.py @@ -363,15 +363,17 @@ def test_baseline_corrected(self): dataset = pt.get_dataset("vaswani") res1 = pt.BatchRetrieve(dataset.get_index(), wmodel="BM25")(dataset.get_topics().head(10)) res2 = pt.BatchRetrieve(dataset.get_index(), wmodel="DPH")(dataset.get_topics().head(10)) - for corr in ['hs', 'bonferroni', 'holm-sidak']: + baseline = 0 + for corr in ['hs', 'bonferroni', 'hommel']: df = pt.Experiment( [res1, res2], dataset.get_topics().head(10), dataset.get_qrels(), eval_metrics=["map", "ndcg"], - baseline=0, correction='hs') + baseline=baseline, correction=corr) self.assertTrue("map +" in df.columns) self.assertTrue("map -" in df.columns) self.assertTrue("map p-value" in df.columns) self.assertTrue("map p-value corrected" in df.columns) self.assertTrue("map reject" in df.columns) + self.assertFalse(any(df["map p-value corrected"].drop(df.index[baseline]).isna()))