Improved API for loading Terrier indices into memory #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's going on here -- can I have a bit of context? |
|
Woops. The pr omitted my explanations or any meaningful title. See https://gist.github.com/cmacdonald/c12ddacd73ad379b3b0f7a8b7cf1d080 |
cmacdonald
commented
Jun 29, 2023
tonellotto
reviewed
Oct 26, 2023
| """ | ||
|
|
||
| @staticmethod | ||
| def _load_into_memory(index, structures=['lexicon', 'direct', 'inverted', 'meta'], load=False): |
There was a problem hiding this comment.
What about document index? It is accessed for getting doc lens, so quite often during ranking.
There was a problem hiding this comment.
document lengths are always in memory. the choice of memory or not relates to the other information, specifically the bits used to access the direct index
tonellotto
reviewed
Oct 26, 2023
cmacdonald
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(WIP)