Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
add `keep_quoted=strict` mode (PR RFC) #304
Bug report or Feature request?
The original PR has died because of lack of interest from maintainers and their insistence that such a transform must only involve changes to a certain set of source files even though the current architecture of uglify makes that impossible. IMHO the PR is as clean as it gets without fundamentally rewriting and fixing underlying architectural issues in uglify.
Link to PR: mishoo/UglifyJS2#3158
I don't mind making it compatible with terser and creating a PR for it, but first I would like to know if you are at all interested or if you're unlikely to accept it anyway. Thoughts?
I see why you have to make changes at multiple stages.
I see you didn't change any other tests to make it work, as it's really low impact.
But! I'd rather you change that new "quote" property to "original_quote". It explains what it's for a bit better.
Also, Terser 4 is coming out and there's plenty to do, so don't expect any attention from me on that PR until 4 is out.
It sounds like you're probably OK with the PR then. But I'll wait until you're done with Terser 4 then, and then I'll port it and submit a proper PR.