Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing keep_numbers in the type of FormatOptions #1208

Closed
anchengjian opened this issue Jun 8, 2022 · 1 comment
Closed

Missing keep_numbers in the type of FormatOptions #1208

anchengjian opened this issue Jun 8, 2022 · 1 comment

Comments

@anchengjian
Copy link

anchengjian commented Jun 8, 2022

Bug report or Feature request?

Typescript Type Check Error:

(property) keep_numbers: boolean
Type '{ toplevel: true; safari10: true; compress: { ecma: 2015 | 5; arrows: boolean; drop_console: boolean; }; } | { compress: false; toplevel: true; safari10: true; output: { comments: false; keep_numbers: boolean; quote_keys: true; }; }' is not assignable to type 'MinifyOptions'.
  Type '{ compress: false; toplevel: true; safari10: true; output: { comments: false; keep_numbers: boolean; quote_keys: true; }; }' is not assignable to type 'MinifyOptions'.
    Types of property 'output' are incompatible.
      Type '{ comments: false; keep_numbers: boolean; quote_keys: true; }' is not assignable to type 'FormatOptions'.

        Object literal may only specify known properties, and 'keep_numbers' does not exist in type 'FormatOptions'.ts(2322)

Version (complete output of terser -V or specific git commit)

Complete CLI command or minify() options used

terser input

terser output or error

Expected result
Add the keep_numbers type to FormatOptions

@fabiosantoscode
Copy link
Collaborator

fabiosantoscode commented Jun 9, 2022

Pushed a fix now, will release tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants