Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prepare and test scripts on Windows #222

Merged
merged 1 commit into from Jan 4, 2019
Merged

Fix prepare and test scripts on Windows #222

merged 1 commit into from Jan 4, 2019

Conversation

L2jLiga
Copy link
Contributor

@L2jLiga L2jLiga commented Jan 3, 2019

  • Updated prepare and test scripts to be able to run on Windows
  • Updated Mocha to 5.2.0 (fixed vulnerabilities alerts)
  • Removed Mochallel (it works unstable)
  • Added Windows builds to TravisCI
  • Updated some other packages

Some notes about mochallel: his behaviour unpredictable for me, it may work fine or broke 3-4 tests with weird errors. If you insist to use mochallel, let's spend time and try to fix it. So, my advise is to use something more stable (like just mocha or mocha-parallel-tests).

@L2jLiga L2jLiga changed the title Fix prepare and test fix on Windows Fix prepare and test scripts on Windows Jan 3, 2019
- Updated prepare and test scripts to be able to run on Windows
- Updated Mocha to 5.2.0 (fixed vulnerabilities alerts)
- Removed Mochallel (it didn't work on Windows)
- Added Windows builds to TravisCI
- Updated some other packages
@fabiosantoscode
Copy link
Collaborator

mocha-parallel-tests doesn't reuse processes, making it quite a bit slower for our case. Nice PR, it goes in. Will release soon!

@fabiosantoscode fabiosantoscode merged commit e3ca27c into terser:master Jan 4, 2019
@L2jLiga L2jLiga deleted the fix-scripts-to-run-on-windows branch January 4, 2019 03:04
@nifgraup nifgraup mentioned this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants