Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node.key crashing lib/compress #286

Merged
merged 3 commits into from Mar 3, 2019
Merged

Conversation

@hytromo
Copy link
Contributor

hytromo commented Feb 23, 2019

Fixes #229

@fabiosantoscode

This comment has been minimized.

Copy link
Collaborator

fabiosantoscode commented Feb 27, 2019

Hey there!

Thanks for the PR :)

This looks like a good change but it needs test coverage. You surely have a piece of code that was crashing Terser, why not use it as a test case?

@fabiosantoscode

This comment has been minimized.

Copy link
Collaborator

fabiosantoscode commented Mar 3, 2019

Great stuff, thanks! It goes in!

@fabiosantoscode fabiosantoscode merged commit d01eb6f into terser:master Mar 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.