Update domprops from FF and Chrome: Is this how? #811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed that some properties of the TextMetrics API were being mangled (actualBoundingBoxAscent, actualBoundingBoxDescent). They aren't present in domprops.js, so I:
pbpaste | sort -u
(note: VSCode does not sort lines correctly...)Are these roughly the steps to update this list? Is there another way? If so, let me know and I'll update this PR. I'm not very familiar with terser's testing conventions, but I've done what I could to get the tests to pass. Not sure if these changes should be expected or not.
Sidenote: when I tried running the tests (and even the commit hook) locally, I received and ESM error in node 12.16.1. I didn't look too deeply into this, but wanted to mention it as it definitely hindered testing before creating this PR. Error below: