Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not Formik instead? #5

Closed
bettiolo opened this issue May 1, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@bettiolo
Copy link

commented May 1, 2019

@bettiolo bettiolo changed the title Why not Formik instead Why not Formik instead? May 1, 2019

@rachelcdavies

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

We are already using DynamicFieldBuilder with Formik in our internal projects. I've made a hack day proposal to mention this possibility in the README for rolling-fields and also write a https://engineering.tes.com/ blog post on about how to combine Formik and rolling-fields.

@bettiolo

This comment has been minimized.

Copy link
Author

commented May 1, 2019

Can you explain better? Is this replacing a React Formik definition with a javascript one?

@sithmel

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Formik is a library to help managing forms.
This is a form fields generator. It allows you to build a form based on a schema.

There are alternatives around, but they are quite inflexible. This is highly customizable and can be integrated with other libraries such as Formik, redux form etc.

@rachelcdavies

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

The point of my hack day proposal is to explain the usage of this project better in both the readme and a blog post.

Basically rolling-fields is for creating a dynamic form based on data which can be wrapped in a Formik form as we already do in our internal projects.

As this repo is public, I can't just add links to our internal Tes usage of it. Hence the idea of a better readme and blog post with generic not Tes specific examples.

@bettiolo

This comment has been minimized.

Copy link
Author

commented May 1, 2019

Formik has a JSX schema AFAIK? rolling-form is translating a javascript definition to a JSX definition like https://github.com/jaredpalmer/formik/blob/master/examples/Basic.js? I am genuinely trying to understand why a Javascript definition is better than a JSX definition (as you would need to specify jsx in both except for trivial use cases)?

@sithmel

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@bettiolo ok, I understand the confusion.
We need for our project to store the form schema in a database. So it has to be serializable.

@rachelcdavies

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@bettiolo I've updated the project readme to better explain the purpose of this project and benefits on top of Formik. Let me know if it is clear enough to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.