Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete move to Java-17 and some clean ups #172

Merged
merged 2 commits into from
Jul 3, 2022

Conversation

HannesWell
Copy link
Contributor

Requires a successful build of eclipse-m2e/m2e-core#834.

@HannesWell HannesWell marked this pull request as ready for review July 3, 2022 17:09
@HannesWell HannesWell merged commit f9f0cf8 into tesla:master Jul 3, 2022
@HannesWell HannesWell deleted the completeJava17 branch July 3, 2022 17:09
@laeubi
Copy link

laeubi commented Jul 4, 2022

If we move to java 17, the version should be bumped to 2.0 as well

@HannesWell
Copy link
Contributor Author

I was not sure about that. In the end this means that all m2e-plugins will have version 2.0?
Which is actually not that bad, since most plugins don't provide an API anyways so there is no SemVer to do.
I'll provide corresponding PRs.

@laeubi
Copy link

laeubi commented Jul 4, 2022

I was not sure about that. In the end this means that all m2e-plugins will have version 2.0?

As mentioned earlier, for me it makes no sense to mix "2.0 m2e" with any "1.x m2e" at all if we do not build against those "older" releases, at least a move of the minimum JDK level is a good reason to bump the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants