Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow http access for P2 in tests #209

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

HannesWell
Copy link
Contributor

No description provided.

@laeubi
Copy link

laeubi commented Jun 16, 2023

Should we probably better change http -> https or is http mandatory for the tests?

@github-actions
Copy link

Test Results

0 files   -    198  0 suites   - 198   0s ⏱️ - 25m 10s
0 tests  -    620  0 ✔️  -    612  0 💤  -   8  0 ±0 
0 runs   - 1 240  0 ✔️  - 1 224  0 💤  - 16  0 ±0 

Results for commit 2f97fa7. ± Comparison against base commit 0652381.

@HannesWell
Copy link
Contributor Author

Should we probably better change http -> https or is http mandatory for the tests?

I tried that first, but http is only used in a local http server set up for the tests and I have no clue how to make that work with https. I assume one would have to create some certificats.
These were the test failures for eclipse-m2e/m2e-core#1429:
https://github.com/eclipse-m2e/m2e-core/runs/14307231704

@HannesWell HannesWell merged commit 06a892c into tesla:master Jun 16, 2023
@HannesWell HannesWell deleted the httpAllowIntests branch June 16, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants