Fix disappearing classpath entries on project update #12

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@fbricon

The new test case couldn't reproduce the issue, but at least can serve as
a non-regression test for the future. New implementation works anyway
(smoke tested) and all existing tests pass.

Also bumped tycho version to 0.18.1

fbricon added some commits Sep 7, 2013
@fbricon fbricon Bump tycho version to 0.18.1, use m2e 1.5
Signed-off-by: Fred Bricon <fbricon@gmail.com>
2a60087
@fbricon fbricon Fix disappearing classpath entries on project update
The new test case couldn't reproduce the issue, but at least can serve as
a non-regression test for the future. New implementation works anyway
(smoke tested) and all existing tests pass.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
531a244
@ifedorenko

I need to use this patch for some time to make sure it does not cause any unwanted side effects.

@jsievers

tested and works for me with the tycho surefire bundles which use surefire jars as nested jars
http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/tycho-surefire

with patch applied, I no longer get errors during Maven > Update Project.

Thanks Fred!

@ifedorenko

I had some odd issues with "normal" projects. While working on m2e maven-3.1.0 branch, PDE wouldn't always propagate changes in maven-bundle-plugin projects to Tycho projects and I had to do some random actions (update dependencies, clean build, update classpath, the infamous pde dance, in other words) to get PDE do recognize the changes. I am not sure if new version is m2e-tycho is really to blame, but this change does not address the root cause -- race condition somewhere inside PDE -- and I'd really hate to trade annoying but obvious problem with nested jars for a problem that is much more obscure and thus harder to troubleshoot. I suggest we use this code at least a week before we decide.

@ifedorenko

pushed to master, but github isn't smart enough to autoclose pull requests. boo.

@ifedorenko ifedorenko closed this Sep 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment