Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn Effects not working #15

Closed
jaku opened this issue May 17, 2021 · 2 comments · Fixed by #16
Closed

Spawn Effects not working #15

jaku opened this issue May 17, 2021 · 2 comments · Fixed by #16

Comments

@jaku
Copy link

jaku commented May 17, 2021

The spawn effects aren't working for a user. Everything else works but running a spawn effect makes the mod disconnect.

The only thing that might be odd is that they have a swedish install of windows.

@BambooleanLogic
Copy link
Contributor

BambooleanLogic commented Aug 30, 2021

I downloaded a bunch of Windows language packs and ran some experiments.

It appears that the problem is not fundamentally caused by your system language, but specifically which "Regional format" setting you use. Below are my findings:

  • Danish
    • Broken for Denmark, Greenland
  • English
    • Works for Canada, Ireland, New Zealand, Puerto Rico, UK, US
  • French
    • Broken for Canada, France, Switzerland
  • German
    • Works for Switzerland
    • Broken for Austria and Germany
  • Spanish
    • Works for Mexico, Puerto Rico, US
    • Broken for Spain, Venezuela
  • Swedish
    • Broken for Åland, Finland, Sweden

@BambooleanLogic
Copy link
Contributor

BambooleanLogic commented Aug 30, 2021

I can't claim to know the first thing about Stardew Valley modding, but I noticed something as I was digging through the code.

Assuming that this decompilation of Stardew Valley is sufficiently accurate, it seems like all the threads it creates contains the following line:

Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture;

I'm also noticing that the threads created by this mod do not appear to contain similar assignments. I therefore posit that Stardew Valley itself might behave in unpredictable ways if called from threads that haven't had their cultures normalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants