Skip to content

Commit

Permalink
simplify hasReportableSlip
Browse files Browse the repository at this point in the history
  • Loading branch information
MarcusDenker committed Jul 20, 2020
1 parent a92de38 commit 793f9ed
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions src/System-Changes/ChangeSet.class.st
Expand Up @@ -1086,16 +1086,11 @@ ChangeSet >> hasPreamble [
ChangeSet >> hasReportableSlip: aMethod [
"Answer whether the receiver contains anything that should be brought
to the attention of the author when filing out. Customize the lists here
to suit your preferences. If slips do not get reported in spite of your
best efforts here, make certain that the Preference 'checkForSlips' is set
to true."
to suit your preferences."

aMethod containsHalt ifTrue: [ ^true ].
#(#flag:) do: [ :aLit | (aMethod hasLiteral: aLit) ifTrue: [ ^ true ] ].
((aMethod literals
select: #isVariableBinding
thenCollect: #key) includes: #Transcript) ifTrue: [ ^true ].
^ false
(aMethod sendsSelector: #flag:) ifTrue: [ ^ true ].
^aMethod readsRef: (Smalltalk globals associationAt: #Transcript)
]

{ #category : #initialization }
Expand Down

0 comments on commit 793f9ed

Please sign in to comment.