-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code update for Node.js 6 capabilities: Tutorials/Pulse_Width_Modulation.md #159
base: master
Are you sure you want to change the base?
Conversation
…ion.md Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
(tessel-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner and clearer! 👏
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
|
||
If your output doesn't match, you should run `t2 update` to get the latest OS and firmware. Once that's done, you're ready to run the program in this tutorial. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HipsterBrown I've added this note about updating Tessel 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwaldron Should this be added to every tutorial page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe adding one line comment at the start of code block inform users, like this:
// Compatible firmware version : greater than 0.1.0.
|
||
-------------------------------------------------------------- | ||
|
||
If you're Tessel 2 is up-to-date, it will be be running Node.js 6.10.3 or newer. You can check that by running `t2 version` and comparing the output to the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: you're > your
|
||
-------------------------------------------------------------- | ||
|
||
If you're Tessel 2 is up-to-date, it will be be running Node.js 6.10.3 or newer. You can check that by running `t2 version` and comparing the output to the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to tie ourselves to listing a specific version here (which will need to be updated?) Is there a future-looking way to accomplish both this and tessel/tessel.io#117
Signed-off-by: Rick Waldron waldron.rick@gmail.com