Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code update for Node.js 6 capabilities: Tutorials/Pulse_Width_Modulation.md #159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rwaldron
Copy link
Contributor

@rwaldron rwaldron commented Jul 7, 2017

Signed-off-by: Rick Waldron waldron.rick@gmail.com

…ion.md

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
@tessel-bot
Copy link

r? @HipsterBrown

(tessel-highfive has picked a reviewer for you, use r? to override)

Copy link
Contributor

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner and clearer! 👏

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>

If your output doesn't match, you should run `t2 update` to get the latest OS and firmware. Once that's done, you're ready to run the program in this tutorial.


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HipsterBrown I've added this note about updating Tessel 2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwaldron Should this be added to every tutorial page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding one line comment at the start of code block inform users, like this:

// Compatible firmware version : greater than 0.1.0.


--------------------------------------------------------------

If you're Tessel 2 is up-to-date, it will be be running Node.js 6.10.3 or newer. You can check that by running `t2 version` and comparing the output to the following:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: you're > your


--------------------------------------------------------------

If you're Tessel 2 is up-to-date, it will be be running Node.js 6.10.3 or newer. You can check that by running `t2 version` and comparing the output to the following:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to tie ourselves to listing a specific version here (which will need to be updated?) Is there a future-looking way to accomplish both this and tessel/tessel.io#117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants