New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "Invalid Command" return value #133

Open
johnnyman727 opened this Issue Dec 7, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@johnnyman727
Contributor

johnnyman727 commented Dec 7, 2015

Currently, if the coprocessor bridge packet parsing software is sent an undefined command, the processor will hang forever. We should handle this by sending back a value that indicates the command was incorrect and corralling that back to the original properly from the SPI Daemon.

@rwaldron

This comment has been minimized.

Show comment
Hide comment
@rwaldron

rwaldron Dec 7, 2015

Contributor

Couldn't this be done before the command is ever sent?

Contributor

rwaldron commented Dec 7, 2015

Couldn't this be done before the command is ever sent?

@reconbot

This comment has been minimized.

Show comment
Hide comment
@reconbot

reconbot Dec 7, 2015

Member

Both? I can see the value in returning an error over dropping bad packets silently. (Crashing is obviously not good.)

Member

reconbot commented Dec 7, 2015

Both? I can see the value in returning an error over dropping bad packets silently. (Crashing is obviously not good.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment