Upgrade to Node 6 #206

Closed
Frijol opened this Issue Sep 1, 2016 · 18 comments

Comments

Projects
None yet
6 participants
@Frijol
Member

Frijol commented Sep 1, 2016

Per
image

It's going to LTS in October, and we should move with it

@tcr

This comment has been minimized.

Show comment
Hide comment
@tcr

tcr Sep 8, 2016

Member

Current tasks:

Member

tcr commented Sep 8, 2016

Current tasks:

@rwaldron

This comment has been minimized.

Show comment
Hide comment
@rwaldron

rwaldron Sep 8, 2016

Contributor

re: iconv/intl/icu

It's more than just iconv, I believe we need to disable intl to avoid inclusion of icu data. https://github.com/nodejs/node/blob/master/configure#L322-L326

@srl295 can you advise?


re: t2-cli

Create precompiled modules for each version, have t2-cli pull them down appropriately

It's not as simple as this bullet implies. I have specific tasks filed across our projects to address each step accordingly. Unfortunately, github offers no way to formally indicate blockers, but each thing must be considered a blocker. I have a plan for t2-cli's path forward, but it requires several other tasks before I implement.

Contributor

rwaldron commented Sep 8, 2016

re: iconv/intl/icu

It's more than just iconv, I believe we need to disable intl to avoid inclusion of icu data. https://github.com/nodejs/node/blob/master/configure#L322-L326

@srl295 can you advise?


re: t2-cli

Create precompiled modules for each version, have t2-cli pull them down appropriately

It's not as simple as this bullet implies. I have specific tasks filed across our projects to address each step accordingly. Unfortunately, github offers no way to formally indicate blockers, but each thing must be considered a blocker. I have a plan for t2-cli's path forward, but it requires several other tasks before I implement.

@tcr

This comment has been minimized.

Show comment
Hide comment
@tcr

tcr Sep 8, 2016

Member

Also @huseyinkozan you did this in your commit huseyinkozan/openwrt-tessel@4d20a94, was that sufficient to bring the size of the Node binary down?

Member

tcr commented Sep 8, 2016

Also @huseyinkozan you did this in your commit huseyinkozan/openwrt-tessel@4d20a94, was that sufficient to bring the size of the Node binary down?

@rwaldron

This comment has been minimized.

Show comment
Hide comment
@rwaldron

rwaldron Sep 8, 2016

Contributor

Also @huseyinkozan you did this in your commit huseyinkozan/openwrt-tessel@4d20a94, was that sufficient to bring the size of the Node binary down?

That looks correct to me, but I would like @srl295 to confirm as well

Contributor

rwaldron commented Sep 8, 2016

Also @huseyinkozan you did this in your commit huseyinkozan/openwrt-tessel@4d20a94, was that sufficient to bring the size of the Node binary down?

That looks correct to me, but I would like @srl295 to confirm as well

@rwaldron

This comment has been minimized.

Show comment
Hide comment
Contributor

rwaldron commented Sep 8, 2016

@huseyinkozan

This comment has been minimized.

Show comment
Hide comment
@huseyinkozan

huseyinkozan Sep 8, 2016

Contributor

Hi all,
@tcr, it is 19 MB. Dont remember the size gain. It just works. The binary below built by the commit you noted. I tried to include libicu and enable it again, but no success.

http://huseyinkozan.com.tr/files/tmp/openwrt-ramips-mt7620-tessel-squashfs-sysupgrade-node-6.2.1-without-intl.bin

Our app is so large (~7MB), and it works on my build. These are the deps:

  "dependencies": {
    "body-parser": "^1.15.1",
    "buffer-layout": "^0.13.0",
    "compression": "^1.6.2",
    "cookie-parser": "^1.4.3",
    "diskspace": "^1.0.3",
    "express": "^4.14.0",
    "express-session": "^1.13.0",
    "fs-extra": "^0.30.0",
    "mathjs": "^3.3.0",
    "moment-timezone": "^0.5.4",
    "multer": "^1.1.0",
    "node-json-db": "^0.7.2",
    "passport": "^0.3.2",
    "passport-http": "^0.3.0",
    "pidusage": "^1.0.1",
    "semantic-ui": "^2.1.8",
    "serialport": "^3.1.2",
    "session-file-store": "^0.2.0",
    "string": "^3.3.1",
    "touch": "^1.0.0"
  }

Serialport library is for PC port. The app serve a semantic-ui GUI, an API on expressjs, and an apidoc static directory. Whole app loads aprox. 40 secs, CPU is setle down after then.

I want to show the demo site, but my bosses want to wait unil finalize our product. : ^ /

I will try to update from upstream and build it again to night (UTC+3).

Contributor

huseyinkozan commented Sep 8, 2016

Hi all,
@tcr, it is 19 MB. Dont remember the size gain. It just works. The binary below built by the commit you noted. I tried to include libicu and enable it again, but no success.

http://huseyinkozan.com.tr/files/tmp/openwrt-ramips-mt7620-tessel-squashfs-sysupgrade-node-6.2.1-without-intl.bin

Our app is so large (~7MB), and it works on my build. These are the deps:

  "dependencies": {
    "body-parser": "^1.15.1",
    "buffer-layout": "^0.13.0",
    "compression": "^1.6.2",
    "cookie-parser": "^1.4.3",
    "diskspace": "^1.0.3",
    "express": "^4.14.0",
    "express-session": "^1.13.0",
    "fs-extra": "^0.30.0",
    "mathjs": "^3.3.0",
    "moment-timezone": "^0.5.4",
    "multer": "^1.1.0",
    "node-json-db": "^0.7.2",
    "passport": "^0.3.2",
    "passport-http": "^0.3.0",
    "pidusage": "^1.0.1",
    "semantic-ui": "^2.1.8",
    "serialport": "^3.1.2",
    "session-file-store": "^0.2.0",
    "string": "^3.3.1",
    "touch": "^1.0.0"
  }

Serialport library is for PC port. The app serve a semantic-ui GUI, an API on expressjs, and an apidoc static directory. Whole app loads aprox. 40 secs, CPU is setle down after then.

I want to show the demo site, but my bosses want to wait unil finalize our product. : ^ /

I will try to update from upstream and build it again to night (UTC+3).

@huseyinkozan

This comment has been minimized.

Show comment
Hide comment
@huseyinkozan

huseyinkozan Sep 8, 2016

Contributor

Previous works:
tessel/openwrt-tessel#58

icu fix comes from:
nodejs/node#7173

Contributor

huseyinkozan commented Sep 8, 2016

Previous works:
tessel/openwrt-tessel#58

icu fix comes from:
nodejs/node#7173

@johnnyman727

This comment has been minimized.

Show comment
Hide comment
@johnnyman727

johnnyman727 Sep 8, 2016

Contributor

Just a note that the Flash size went down to ~14.5MB when we swapped ffmpeg for mpeg-streamer in 0.0.14.

Contributor

johnnyman727 commented Sep 8, 2016

Just a note that the Flash size went down to ~14.5MB when we swapped ffmpeg for mpeg-streamer in 0.0.14.

@rwaldron

This comment has been minimized.

Show comment
Hide comment
@rwaldron

rwaldron Sep 8, 2016

Contributor

@huseyinkozan rad :)

Contributor

rwaldron commented Sep 8, 2016

@huseyinkozan rad :)

@huseyinkozan

This comment has been minimized.

Show comment
Hide comment
@huseyinkozan

huseyinkozan Sep 8, 2016

Contributor

@johnnyman727, how much before ? Is this for app usage ?

Contributor

huseyinkozan commented Sep 8, 2016

@johnnyman727, how much before ? Is this for app usage ?

@johnnyman727

This comment has been minimized.

Show comment
Hide comment
@johnnyman727

johnnyman727 Sep 8, 2016

Contributor

@huseyinkozan it was at about 19MB before. This is just the base OpenWRT image that sits in Flash. App usage will vary by app.

Contributor

johnnyman727 commented Sep 8, 2016

@huseyinkozan it was at about 19MB before. This is just the base OpenWRT image that sits in Flash. App usage will vary by app.

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 Sep 9, 2016

hi all! @huseyinkozan you said

I tried to include libicu and enable it again, but no success

can you get me more details? Sounds like a separate issue is in order at this point, --without-intl is probably the best step at this point.

srl295 commented Sep 9, 2016

hi all! @huseyinkozan you said

I tried to include libicu and enable it again, but no success

can you get me more details? Sounds like a separate issue is in order at this point, --without-intl is probably the best step at this point.

@huseyinkozan

This comment has been minimized.

Show comment
Hide comment
@huseyinkozan

huseyinkozan Sep 9, 2016

Contributor

Sorry @srl295, didnt see your message at here. I wrote a detailed one at nodejs/node#7173 (comment). But that was not the case that you quote.

I had build libicu with OpenWRT environment, but couldnt say node to use this at OpenWRT packaging file.

libicu package Makefile for OpenWRT:
https://github.com/huseyinkozan/openwrt-tessel/blob/node-6.2.1/package/openwrt-addpack/icu/Makefile

Node package Makefile for OpenWRT:
https://github.com/huseyinkozan/openwrt-tessel/blob/node-6.2.1/package/node/node/Makefile

Note: I am using Node 6.5.0 now.

Contributor

huseyinkozan commented Sep 9, 2016

Sorry @srl295, didnt see your message at here. I wrote a detailed one at nodejs/node#7173 (comment). But that was not the case that you quote.

I had build libicu with OpenWRT environment, but couldnt say node to use this at OpenWRT packaging file.

libicu package Makefile for OpenWRT:
https://github.com/huseyinkozan/openwrt-tessel/blob/node-6.2.1/package/openwrt-addpack/icu/Makefile

Node package Makefile for OpenWRT:
https://github.com/huseyinkozan/openwrt-tessel/blob/node-6.2.1/package/node/node/Makefile

Note: I am using Node 6.5.0 now.

@huseyinkozan

This comment has been minimized.

Show comment
Hide comment
@huseyinkozan

huseyinkozan Sep 10, 2016

Contributor

Yes. I give up with icu. I built with --without-intl option. My trials are here :
https://github.com/huseyinkozan/openwrt-tessel/tree/node-6.5.0

Built files :
http://huseyinkozan.com.tr/files/tmp/

process.versions:

{ http_parser: '2.7.0',
  node: '6.5.0',
  v8: '5.1.281.81',
  uv: '1.9.1',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  modules: '48',
  openssl: '1.0.2d' }
Contributor

huseyinkozan commented Sep 10, 2016

Yes. I give up with icu. I built with --without-intl option. My trials are here :
https://github.com/huseyinkozan/openwrt-tessel/tree/node-6.5.0

Built files :
http://huseyinkozan.com.tr/files/tmp/

process.versions:

{ http_parser: '2.7.0',
  node: '6.5.0',
  v8: '5.1.281.81',
  uv: '1.9.1',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  modules: '48',
  openssl: '1.0.2d' }

@huseyinkozan huseyinkozan referenced this issue in tessel/openwrt-tessel Sep 13, 2016

Closed

Node 6.5.0 #68

@huseyinkozan

This comment has been minimized.

Show comment
Hide comment
@huseyinkozan

This comment has been minimized.

Show comment
Hide comment
@huseyinkozan

huseyinkozan Jul 24, 2017

Contributor

Still open ?

Contributor

huseyinkozan commented Jul 24, 2017

Still open ?

@rwaldron

This comment has been minimized.

Show comment
Hide comment
@rwaldron

rwaldron Jul 25, 2017

Contributor

Whoops! Thanks for follow up

Contributor

rwaldron commented Jul 25, 2017

Whoops! Thanks for follow up

@rwaldron rwaldron closed this Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment