Skip to content

Conversation

@namsonx
Copy link
Collaborator

@namsonx namsonx commented Jul 20, 2023

No description provided.

@HolQue
Copy link
Collaborator

HolQue commented Jul 20, 2023

Hi Son,

there is a merge conflict with

origin/namsonx/fixbug/98/memory_interferences

Please resolve.

@namsonx
Copy link
Collaborator Author

namsonx commented Jul 20, 2023

Hi Holger,

I merged the conflict in branch namsonx/testing/testing_branch

Thank you,
Son

Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
please solve the merge conflict.
Thank you,
Thomas

@namsonx
Copy link
Collaborator Author

namsonx commented Aug 2, 2023

Hello Thomas,

Conflict was resolved.

Thank you,
Son

Copy link
Collaborator

@HolQue HolQue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,

I do not understand what is going on here. Comparing the test log file of this branch with the test log file of your test branch some days ago, I observe that two more test cases fail. Reason is that a previously fixed issue is back:

Found deviating return values
(1) '[DICT] (51/7) > {param_07} [STR]  :  'true''   > (expected)
(2) '[DICT] (51/7) > {param_07} [STR]  :  '"true"''   > (returned)

What exactly shall be improved in this pull request? It would be helpful to refer to a concrete issue when you provide fixes.

@namsonx
Copy link
Collaborator Author

namsonx commented Aug 2, 2023

Hello Holger,

The issue you mentioned above is fixed in other pull-request #110 which is not yet merged.
All latest commits were merged to my testing branch - namsonx/testing/testing_branch. Could you please verify issue using this testing branch?

Thank you,
Son

@namsonx namsonx closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants