Minior update variable name #112
Conversation
namsonx
requested review from
HolQue,
huavanthong,
milanac030988,
ngoan1608,
test-fullautomation,
tranhoangnguyen193 and
trimai3001
There was a problem hiding this comment.
Hi Son,
the variable is renamed only once in constructor. At all further positions still the old name is present.
I wonder how this can work. Because: When you work with a variable, but you do not initialize this variable in constructor any more (like previously), and this has no consequences, no errors, then you have a severe issues in your software architecture. Please check your code.
Addendum: I overlooked the error message!
JsonPreprocessor throws exception now:
''CJsonPreprocessor' object has no attribute 'lUpdatedParams''!
|
Hi Son, impact of this issue much higher than expected: |
|
Hello Holger, Opps, sorry my mistake. I forgot update other locations. Thank you, |
test-fullautomation
left a comment
test-fullautomation
left a comment
There was a problem hiding this comment.
Hi Son,
looks good to me!
Thank you,
Thomas
No description provided.